docs: typo in BlueGreen #3463
Merged
docs: typo in BlueGreen #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3463 +/- ##
==========================================
+ Coverage 81.83% 82.81% +0.97%
==========================================
Files 135 135
Lines 20688 16998 -3690
==========================================
- Hits 16931 14077 -2854
+ Misses 2883 2034 -849
- Partials 874 887 +13 ☔ View full report in Codecov by Sentry. |
Go Published Test Results2 142 tests 2 142 ✅ 2m 51s ⏱️ Results for commit 98ae3a0. |
E2E Tests Published Test Results 4 files 4 suites 3h 43m 18s ⏱️ For more details on these failures, see this check. Results for commit 98ae3a0. |
zachaller
approved these changes
Mar 22, 2024
shubhajyoti-bagchi-groww
pushed a commit
to shubhajyoti-bagchi-groww/argo-rollouts
that referenced
this pull request
Mar 23, 2024
Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in>
shubhajyoti-bagchi-groww
pushed a commit
to shubhajyoti-bagchi-groww/argo-rollouts
that referenced
this pull request
Mar 24, 2024
Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in>
zachaller
pushed a commit
that referenced
this pull request
Mar 26, 2024
… following a canary abort for istio trafficrouting (#3467) * chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch from 1.36.1 to 1.36.3 (#3452) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.36.1 to 1.36.3. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/ec2/v1.36.1...service/ssm/v1.36.3) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * controller: Fixed negative canary weight bug for istio trafficrouting Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * Added e2e test to validate the fix Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * Removed local changes Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * linted as per golangci-lint run Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * docs: typo in BlueGreen (#3463) Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * chore(deps): bump slsa-framework/slsa-github-generator from 1.9.1 to 1.10.0 (#3462) chore(deps): bump slsa-framework/slsa-github-generator Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.9.1 to 1.10.0. - [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases) - [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) - [Commits](slsa-framework/slsa-github-generator@v1.9.1...v1.10.0) --- updated-dependencies: - dependency-name: slsa-framework/slsa-github-generator dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 from 1.30.3 to 1.30.4 (#3461) chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 Bumps [github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2](https://github.com/aws/aws-sdk-go-v2) from 1.30.3 to 1.30.4. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.30.3...service/s3/v1.30.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * Removed sleep and waited for 1 replicas Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> * Moved up canary weight test to match PR title Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: shubhajyoti-bagchi-groww <shubhajyoti.bagchi@groww.in> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Thanapat Chotipun <66824385+PatrickChoDev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".