Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): improve pods visibility #3483

Merged

Conversation

alopezsanchez
Copy link
Contributor

@alopezsanchez alopezsanchez commented Mar 29, 2024

This commit adds two improvements to the Pods view:

  • Show spinner (pending status) while the pod is running but not ready (like ArgoCD UI does)
  • Show the ready property on the tooltip

The motivation is that having them green is a bit confusing when they are not ready to serve traffic, especially during the step of setWeight in a canary.

Some screenshots of the changes:

Screenshot 2024-03-29 at 10 22 43
Screenshot 2024-03-29 at 10 16 18

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link
Contributor

github-actions bot commented Mar 29, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 43m 26s ⏱️
110 tests 102 ✅  6 💤 2 ❌
442 runs  416 ✅ 24 💤 2 ❌

For more details on these failures, see this check.

Results for commit d99b53c.

♻️ This comment has been updated with latest results.

@alopezsanchez alopezsanchez force-pushed the replicasets-pods-view-improvements branch 2 times, most recently from 657ca90 to c96740b Compare March 29, 2024 09:45
@alopezsanchez alopezsanchez changed the title feat(ui): improve pods visibility feat(dashboard): improve pods visibility Mar 29, 2024
Copy link
Contributor

github-actions bot commented Mar 29, 2024

Go Published Test Results

2 144 tests   2 144 ✅  2m 51s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit d99b53c.

♻️ This comment has been updated with latest results.

This commit adds two improvements to the Pods view:
* Show spinner (pending status) while the pod is not ready (like ArgoCD UI does)
* Show the `ready` property on the tooltip

Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co>
@alopezsanchez alopezsanchez force-pushed the replicasets-pods-view-improvements branch from c96740b to d99b53c Compare March 29, 2024 09:50
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.79%. Comparing base (8405f2e) to head (d99b53c).
Report is 61 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3483      +/-   ##
==========================================
+ Coverage   81.83%   82.79%   +0.95%     
==========================================
  Files         135      135              
  Lines       20688    17032    -3656     
==========================================
- Hits        16931    14101    -2830     
+ Misses       2883     2041     -842     
- Partials      874      890      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaller zachaller merged commit 190c42a into argoproj:master Mar 29, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants