Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource step jsonPath output is unnecessary quoted #1199

Closed
alexmt opened this issue Jan 30, 2019 · 1 comment
Closed

Resource step jsonPath output is unnecessary quoted #1199

alexmt opened this issue Jan 30, 2019 · 1 comment

Comments

@alexmt
Copy link
Contributor

alexmt commented Jan 30, 2019

Is this a BUG REPORT or FEATURE REQUEST?:

Bug

What happened:

The output of step resource of jsonPath is always quoted. Quotes are added by following line:

https://github.com/argoproj/argo/blob/149d176fdf3560d74afa91fe91a0ee38bf7ec3bd/workflow/executor/resource.go#L231

which is equivalent to

kubectl get some resource "-o=jsonpath='{.status.some-field}'"

What you expected to happen:

Quotes should be added by user if necessary

How to reproduce it (as minimally and precisely as possible):

argo submit test/e2e/functional/k8s-jobs.yaml

Environment:

  • Argo version: 2.2.1
@alexmt
Copy link
Contributor Author

alexmt commented Feb 25, 2019

Fixed #1232

@alexmt alexmt closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexmt