Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Support markdown in CronWorkflow/WorkflowTemplate title/description #12644

Closed
panicboat opened this issue Feb 9, 2024 · 3 comments · Fixed by #12674 or #12697
Closed

UI: Support markdown in CronWorkflow/WorkflowTemplate title/description #12644

panicboat opened this issue Feb 9, 2024 · 3 comments · Fixed by #12674 or #12697
Assignees
Labels
area/ui good first issue Good for newcomers solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/feature Feature request

Comments

@panicboat
Copy link
Contributor

Summary

I would like to use markdowns not only in the Workflow list, but also in the CronWorkflow / WorkflowTemplate list.

Use Cases

We want to have the title read as a reminder before executing a workflow.
Also, we want to have flexibility in displaying titles.


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.

@panicboat panicboat added the type/feature Feature request label Feb 9, 2024
@agilgur5 agilgur5 changed the title Allow for markdown in CronWorkflow/WorkflowTemplate title/description in UI UI: Support markdown in CronWorkflow/WorkflowTemplate title/description Feb 9, 2024
@panicboat
Copy link
Contributor Author

panicboat commented Feb 15, 2024

Can I work on this issue?
Looks good as a Good First Issue.
Ref: #10553

@agilgur5
Copy link
Contributor

agilgur5 commented Feb 16, 2024

I would start with plain title & description (like #9805) and then add markdown, as that is more complex and has some performance ramifications due to the new deps, per my review #10553 (review).

The resulting code from my modifications in #12580 is a lot more optimized, as well as fixes several bugs from the original PR.

Otherwise I think you can take this one as it is indeed fairly straightforward. Start with a PR for plain title & description, then can add optional markdown support to it

@agilgur5 agilgur5 added good first issue Good for newcomers solution/suggested A solution to the bug has been suggested. Someone needs to implement it. labels Feb 16, 2024
@agilgur5 agilgur5 reopened this Feb 18, 2024
@agilgur5
Copy link
Contributor

Non-markdown was complete for CronWorkflows in #12674, re-opening to continue for markdown and for WorkflowTemplates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment