Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.5.7+ changes some http response status codes from GET Workflow #13557

Closed
3 of 4 tasks
clarity-ai opened this issue Sep 5, 2024 · 3 comments
Closed
3 of 4 tasks

v3.5.7+ changes some http response status codes from GET Workflow #13557

clarity-ai opened this issue Sep 5, 2024 · 3 comments
Labels
area/api Argo Server API solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@clarity-ai
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

In the latest images some endpoints change their status responses.

When a call this endpoints:

  • Calling the API with an invalid token.
  • Calling the API with a token without enough permissions.

I start returning a 404 when in previous version (3.4.x) the status code was a 401.

Also when:

  • Calling the API to stop a non existing workflow.
  • Calling the API to resume a non existing workflow.
    I stop returning a 404 when in previous version (3.4.x) the status code was a 404.

Version(s)

v3.5.x

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

It's an http call, not related with the workflow itself.

Logs from the workflow controller

Nothing to show.

Logs from in your workflow's wait container

Nothing to show.
@agilgur5
Copy link
Member

agilgur5 commented Sep 5, 2024

Looks like this was duplicated/superseded by #13558 by a different user. Please try not to open multiple duplicate issues as issues are permanent and it is more to keep track of.

@agilgur5 agilgur5 added type/regression Regression from previous behavior (a specific type of bug) area/api Argo Server API solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) labels Sep 5, 2024
@agilgur5 agilgur5 changed the title v3.5.5 changes the http response status codes v3.5.x changes the http response status codes Sep 5, 2024
@pmareke
Copy link
Contributor

pmareke commented Sep 6, 2024

Yeah it was me with another account, my fault sorry.

Would you mind to delete it? I can't do it by myself.

@agilgur5
Copy link
Member

agilgur5 commented Sep 6, 2024

There's no way to delete issues 😕. Only GH support can do it and that's usually only for a security reason (publicly exposed token or vuln, etc)

@agilgur5 agilgur5 changed the title v3.5.x changes the http response status codes v3.5.7+ changes some http response status codes from GET Workflow Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Argo Server API solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

No branches or pull requests

3 participants