Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in the UI when clicking on "Completed Workflows" button #14098

Open
4 tasks done
yellow-straw-hat opened this issue Jan 17, 2025 · 3 comments
Open
4 tasks done

Comments

@yellow-straw-hat
Copy link

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

I have deployed a workflow, and it's finished.
Check screenshot :

Image

When I click on "Completed Workflows" button, the link changes to: http://workflows/?label=workflows.argoproj.io/completed=true

So it changes the protocole scheme to http and it omits the dns name : my_argo_ui/
Expected Behavior:
https://my_argo_ui/workflows/?label=workflows.argoproj.io/completed=true_

Version(s)

v3.6.2

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflow that uses private images.

Any workflow

Logs from the workflow controller

time="2025-01-17T16:31:43.709Z" level=info duration="49.602µs" method=GET path=index.html size=487 status=0

Logs from in your workflow's wait container

time="2025-01-17T16:31:43.709Z" level=info duration="49.602µs" method=GET path=index.html size=487 status=0
@shuangkun
Copy link
Member

- name: Completed Workflows

Could you try to modify this configuration?

@yellow-straw-hat
Copy link
Author

I have set it to https://localhost:2746/workflows?label=workflows.argoproj.io/completed=true, and it works now.
In the same config, I'm seeing that that all urls are hardcoded (with http:// scheme and without server:[port]). Is this done on purpose or it should be fixed ?

@shuangkun
Copy link
Member

I have set it to https://localhost:2746/workflows?label=workflows.argoproj.io/completed=true, and it works now. In the same config, I'm seeing that that all urls are hardcoded (with http:// scheme and without server:[port]). Is this done on purpose or it should be fixed ?

The example shown here is that you can customize your config to modify these URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants