fix: use quay.io for third-party images to avoid rate limiting. Fixes #10807 #14239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A major source of flaky CI builds for Argo Workflows is Docker Hub image limits. Here's an example: > [port-forward] (starting) [pods/minio-769877b9db-6j8gt] (Waiting) ErrImagePull: container "main" is waiting: Error response from daemon: toomanyrequests: You have reached your unauthenticated pull rate limit. https://www.docker.com/increase-rate-limit Source: https://github.com/argoproj/argo-workflows/actions/runs/13519739393/job/37776381312?pr=14215 On April 1st, Docker Hub is further reducing the limits, so I expect this is going to get worse. This switches the images used in the manifests (which are in turn used by the E2E tests) to use equivalent images on quay.io: * https://hub.docker.com/r/minio/minio -> https://quay.io/minio/minio * https://hub.docker.com/r/kong/httpbin - quay.io/holos/mccutchen/go-httpbin * https://hub.docker.com/_/mysql/tags?name=8 - https://quay.io/fedora/mysql-80 * https://hub.docker.com/_/postgres/tags?name=12-alpine - https://quay.io/repository/fedora/postgresql-12 * https://hub.docker.com/r/prom/prometheus/ - https://quay.io/repository/prometheus/prometheus I also switched all images to use the manifest digest so we don't need to worry about an image suddenly changing and causing all builds to fail (and also partly for security). Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
terrytangyuan
approved these changes
Mar 2, 2025
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
MasonM
commented
Mar 2, 2025
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
|
/retest |
MasonM
commented
Mar 2, 2025
| @@ -12,7 +12,7 @@ stringData: | |||
| # for oauth2 authentication | |||
| clientID: admin | |||
| clientSecret: password | |||
| tokenURL: "http://httpbin:9100/response-headers?access_token=faketoken&token_type=Bearer" # this URL will return a body with the "access_token" field set and can simulate an oauth token flow | |||
| tokenURL: "http://httpbin:9100/base64/YWNjZXNzX3Rva2VuPWZha2V0b2tlbg==" # this URL will return a body with the "access_token" field set and can simulate an oauth token flow | |||
There was a problem hiding this comment.
Had to change this because go-httpbin gives different responses for this endpoint: mccutchen/go-httpbin#141
MasonM
commented
Mar 2, 2025
Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
|
/retest |
|
/retest |
blkperl
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #10807
Motivation
A major source of flaky CI builds for Argo Workflows is Docker Hub image limits. Here's an example:
On April 1st, Docker Hub is further reducing the limits, so I expect this is going to get worse.
Modifications
This switches the images used in the manifests (which are in turn used by the E2E tests) to use equivalent images on quay.io:
I also switched all images to use the manifest digest so we don't need to worry about an image suddenly changing and causing all builds to fail (and also partly for security).
Verification
E2E tests
Documentation
I couldn't find anything that needs to change, but let me know if I missed anything