Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples do not validate by api/jsonschema/schema.json #4602

Closed
brabster opened this issue Nov 26, 2020 · 0 comments · Fixed by #4611
Closed

Examples do not validate by api/jsonschema/schema.json #4602

brabster opened this issue Nov 26, 2020 · 0 comments · Fixed by #4611
Labels

Comments

@brabster
Copy link
Contributor

Summary

Content of examples on master should validate against the JSON schema on master

Diagnostics

Issues with

  • string-or-int (eg. for port numbers) - can be fixed by setting schema type to "type": ["string", "int"]
  • string-or-number (eg. workflow parameters defaults & values) - can be fixed by setting schema type to "type": ["string", "number"] - are they parsed or should these really be limited to strings?
  • int64 and int32 as "format" for "type":"integer" not valid JSON schema - remove format keys
  • examples/memoize-simple.yaml doesn't validate, io.k8s.api.core.v1.ConfigMapKeySelector is missing property "key"
  • a couple of examples have naked keys and need data structures [] or {} to be specified

Incoming PR has a diff showing changes to fix - not sure whether the changes need to be made directly in the schema or in some code that generates the schema


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant