Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support archived workflows logs in UI from archived logs #7830

Closed
alexec opened this issue Feb 8, 2022 · 6 comments
Closed

Support archived workflows logs in UI from archived logs #7830

alexec opened this issue Feb 8, 2022 · 6 comments

Comments

@alexec
Copy link
Contributor

alexec commented Feb 8, 2022

Summary

Currently, if you open an archived workflow, you are not able to see logs in the log viewer, even if the logs were archived to 'main.log'. We could fix this.

Use Cases

When would you use this?


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@tczhao
Copy link
Member

tczhao commented Feb 13, 2022

Hi @alexec , would you mind providing more details on this.
I couldn't get my head around what you meant by "Support archived workflows logs in UI from archived logs".
All I'm thinking right now is we can view the archived logs from archived workflows

@noam-codefresh
Copy link
Contributor

If I understand correctly - the current UI does not make the request to get the logs (output artifacts) by the workflow's UID? because the server's endpoint for it exist.

@asfaltboy
Copy link

Does this relate to the Log UI "All" option not showing nothing after pods are garbage collected? Or, should that be considered a separate issue?

On a side note, what does this recommendation in the docs mean?:

⚠️ We do not recommend you rely on Argo Workflows to archive logs. Instead, use a conventional Kubernetes logging facility.

Are there some known issues? Also, does kubernetes provide any facility for collecting and returning logs for garbage collected pods, and then can argo workflows use this facility? I ask because viewing logs in the argo workflows UI is very convenient, and one of the main "selling points" of the application in my mind

@agilgur5
Copy link
Member

agilgur5 commented Aug 23, 2023

Does this relate to the Log UI "All" option not showing nothing after pods are garbage collected? Or, should that be considered a separate issue?

Not quite. That is a Kubernetes limitation, not an Argo issue. k8s no longer has logs after the Pods are GC'd.
The archive logs feature is one way around that, as is using a conventional logging facility.

Also, does kubernetes provide any facility for collecting and returning logs for garbage collected pods, and then can argo workflows use this facility?

A pretty conventional cluster set-up is to have fluentd / fluent-bit as a DaemonSet collecting logs from all nodes and sending those to a log provider (e.g. Splunk, Logstash, etc).
That would be an interesting feature if Workflows could use it, as it is indeed convenient. As a workaround to that, you can add an external link to a query in your log provider. Not specific to this issue though.

EDIT: The archive logs docs are getting more specific improvements around recommendations in #12597

@agilgur5
Copy link
Member

agilgur5 commented Aug 23, 2023

Not sure if #11121 ended up fixing this as well. cc @terrytangyuan

@terrytangyuan
Copy link
Member

It's supported. Re-open if not.

@agilgur5 agilgur5 added area/artifacts S3/GCP/OSS/Git/HDFS etc area/archive-logs Archive Logs feature and removed area/artifacts S3/GCP/OSS/Git/HDFS etc labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants