Skip to content

Commit 0344851

Browse files
authored
Merge pull request #16257 from argotorg/migrate-to-ghcr
Migrate to ghcr
2 parents e403242 + 10c8749 commit 0344851

File tree

7 files changed

+38
-29
lines changed

7 files changed

+38
-29
lines changed

.circleci/config.yml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,25 @@ version: 2.1
99
parameters:
1010
ubuntu-2004-docker-image:
1111
type: string
12-
# solbuildpackpusher/solidity-buildpack-deps:ubuntu2004-26
13-
default: "solbuildpackpusher/solidity-buildpack-deps@sha256:1f387a77be889f65a2a25986a5c5eccc88cec23fabe6aeaf351790751145c81e"
12+
# ghcr.io/argotorg/solidity-buildpack-deps:ubuntu2004-26
13+
default: "ghcr.io/argotorg/solidity-buildpack-deps@sha256:1f387a77be889f65a2a25986a5c5eccc88cec23fabe6aeaf351790751145c81e"
1414
ubuntu-2404-docker-image:
1515
type: string
16-
# solbuildpackpusher/solidity-buildpack-deps:ubuntu2404-6
17-
default: "solbuildpackpusher/solidity-buildpack-deps@sha256:c0412c53e59ce0c96bde4c08e7332ea12e4cadba9bbac829621947897fa21272"
16+
# ghcr.io/argotorg/solidity-buildpack-deps:ubuntu2404-6
17+
default: "ghcr.io/argotorg/solidity-buildpack-deps@sha256:c0412c53e59ce0c96bde4c08e7332ea12e4cadba9bbac829621947897fa21272"
1818
ubuntu-2404-clang-docker-image:
1919
type: string
20-
# solbuildpackpusher/solidity-buildpack-deps:ubuntu2404.clang-7
21-
default: "solbuildpackpusher/solidity-buildpack-deps@sha256:7466ed23590cf14e60da884894723bcdab064742f017dcfcce015999b4f9143b"
20+
# ghcr.io/argotorg/solidity-buildpack-deps:ubuntu2404.clang-7
21+
default: "ghcr.io/argotorg/solidity-buildpack-deps@sha256:7466ed23590cf14e60da884894723bcdab064742f017dcfcce015999b4f9143b"
2222
ubuntu-clang-ossfuzz-docker-image:
2323
type: string
24-
# solbuildpackpusher/solidity-buildpack-deps:ubuntu.clang.ossfuzz-12
25-
default: "solbuildpackpusher/solidity-buildpack-deps@sha256:c7088af5082bf764244a6251ecf3dd29d280d2cd2cd071f011f7f32e0326f426"
24+
# ghcr.io/argotorg/solidity-buildpack-deps:ubuntu.clang.ossfuzz-12
25+
default: "ghcr.io/argotorg/solidity-buildpack-deps@sha256:c7088af5082bf764244a6251ecf3dd29d280d2cd2cd071f011f7f32e0326f426"
2626
emscripten-docker-image:
2727
type: string
2828
# NOTE: Please remember to update the `scripts/build_emscripten.sh` whenever the hash of this image changes.
29-
# solbuildpackpusher/solidity-buildpack-deps:emscripten-21
30-
default: "solbuildpackpusher/solidity-buildpack-deps@sha256:fc53d68a4680ffa7d5f70164e13a903478964f15bcc07434d74833a05f4fbc19"
29+
# ghcr.io/argotorg/solidity-buildpack-deps:emscripten-21
30+
default: "ghcr.io/argotorg/solidity-buildpack-deps@sha256:fc53d68a4680ffa7d5f70164e13a903478964f15bcc07434d74833a05f4fbc19"
3131
evm-version:
3232
type: string
3333
default: prague
@@ -1866,7 +1866,7 @@ jobs:
18661866
command: scripts/docker_deploy_manual.sh develop "file://$PWD" --no-push
18671867
- run:
18681868
name: Smoke test
1869-
command: docker run --pull=never ethereum/solc:build-alpine --version
1869+
command: docker run --pull=never ghcr.io/argotorg/solc:build-alpine --version
18701870
- matrix_notify_failure_unless_pr
18711871

18721872
workflows:

.github/workflows/buildpack-deps.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ jobs:
1616
buildpack-deps:
1717
env:
1818
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
19-
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
20-
DOCKER_REPOSITORY: solbuildpackpusher/solidity-buildpack-deps
19+
DOCKER_REPOSITORY: ghcr.io/argotorg/solidity-buildpack-deps
2120
IMAGE_NAME: buildpack-deps
2221

2322
runs-on: ubuntu-latest
@@ -32,11 +31,16 @@ jobs:
3231
with:
3332
fetch-depth: 0
3433

34+
- name: Log in to GitHub Container Registry
35+
uses: docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef # v3.6.0
36+
with:
37+
registry: ghcr.io
38+
username: ${{ github.actor }}
39+
password: ${{ secrets.GITHUB_TOKEN }}
40+
3541
- name: Upgrade ${{ env.IMAGE_NAME }}-${{ matrix.image_variant }}
3642
run: |
37-
echo ${DOCKERHUB_TOKEN} | docker login -u solbuildpackpusher --password-stdin
3843
scripts/ci/docker_upgrade.sh ${{ env.IMAGE_NAME }} ${{ matrix.image_variant }} ${{ env.DOCKER_REPOSITORY }}
39-
docker logout
4044
4145
- name: comment PR
4246
if: "env.DOCKER_IMAGE"

docs/installing-solidity.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ Please refer to the solc-js repository for instructions.
7171
Docker
7272
======
7373

74-
Docker images of Solidity builds are available using the ``solc`` image from the ``ethereum`` organization.
74+
Docker images of Solidity builds are available using the `solc <https://github.com/argotorg/solidity/pkgs/container/solc>`_ image from the argotorg organization on ghcr.io.
7575
Use the ``stable`` tag for the latest released version, and ``nightly`` for potentially unstable changes in the ``develop`` branch.
7676

7777
The Docker image runs the compiler executable so that you can pass all compiler arguments to it.
@@ -80,11 +80,11 @@ and runs it in a new container, passing the ``--help`` argument.
8080

8181
.. code-block:: bash
8282
83-
docker run ethereum/solc:stable --help
83+
docker run ghcr.io/argotorg/solc:stable --help
8484
8585
.. note::
8686

87-
Specific compiler versions are supported as the Docker image tag such as ``ethereum/solc:0.8.23``.
87+
Specific compiler versions are supported as the Docker image tag such as ``ghcr.io/argotorg/solc:0.8.23``.
8888
We will be passing the ``stable`` tag here instead of specific version tag to ensure that users get
8989
the latest version by default and avoid the issue of an out-of-date version.
9090

@@ -95,7 +95,7 @@ local folder for input and output, and specify the contract to compile. For exam
9595
9696
docker run \
9797
--volume "/tmp/some/local/path/:/sources/" \
98-
ethereum/solc:stable \
98+
ghcr.io/argotorg/solc:stable \
9999
/sources/Contract.sol \
100100
--abi \
101101
--bin \
@@ -108,7 +108,7 @@ self-contained (i.e. it does not refer to any external files that would have to
108108

109109
.. code-block:: bash
110110
111-
docker run ethereum/solc:stable --standard-json < input.json > output.json
111+
docker run ghcr.io/argotorg/solc:stable --standard-json < input.json > output.json
112112
113113
Linux Packages
114114
==============

scripts/Dockerfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
FROM alpine AS build
2-
MAINTAINER chriseth <chris@ethereum.org>
3-
#Official solidity docker image
42

53
#Establish working directory as solidity
64
WORKDIR /solidity
75

86
# Build dependencies
97
RUN apk update && apk add boost-dev boost-static build-base cmake git clang
108

11-
#Copy working directory on travis to the image
12-
COPY / $WORKDIR
9+
#Copy working directory to the image
10+
COPY . /solidity
1311

1412
# Number of parallel jobs during build
1513
# or 0 for auto-computing (max(1, CPU_core_count * 2/3), a greedy value)
@@ -34,5 +32,7 @@ RUN make solc \
3432
RUN strip solc/solc
3533

3634
FROM scratch
35+
LABEL org.opencontainers.image.source=https://github.com/argotorg/solidity
36+
LABEL maintainer="Solidity Team <solidity@argot.org>"
3737
COPY --from=build /solidity/solc/solc /usr/bin/solc
3838
ENTRYPOINT ["/usr/bin/solc"]

scripts/Dockerfile_alpine

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
FROM alpine
2-
MAINTAINER chriseth <chris@ethereum.org>
2+
LABEL org.opencontainers.image.source=https://github.com/argotorg/solidity
3+
LABEL maintainer="Solidity Team <solidity@argot.org>"
34

45
COPY upload/solc-static-linux /usr/local/bin/solc
56
ENTRYPOINT ["/usr/local/bin/solc"]

scripts/build_emscripten.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ if (( $# != 0 )); then
3333
params="$(printf "%q " "${@}")"
3434
fi
3535

36-
# solbuildpackpusher/solidity-buildpack-deps:emscripten-21
36+
# ghcr.io/argotorg/solidity-buildpack-deps:emscripten-21
3737
# NOTE: Without `safe.directory` git would assume it's not safe to operate on /root/project since it's owned by a different user.
3838
# See https://github.blog/2022-04-12-git-security-vulnerability-announced/
3939
docker run -v "$(pwd):/root/project" -w /root/project \
40-
solbuildpackpusher/solidity-buildpack-deps@sha256:fc53d68a4680ffa7d5f70164e13a903478964f15bcc07434d74833a05f4fbc19 \
40+
ghcr.io/argotorg/solidity-buildpack-deps@sha256:fc53d68a4680ffa7d5f70164e13a903478964f15bcc07434d74833a05f4fbc19 \
4141
/bin/bash -c "git config --global --add safe.directory /root/project && ./scripts/ci/build_emscripten.sh ${params}"

scripts/docker_deploy_manual.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ REPO_ROOT="$(dirname "$0")/.."
66
# shellcheck source=scripts/common.sh
77
source "${REPO_ROOT}/scripts/common.sh"
88

9-
image="ethereum/solc"
9+
image="ghcr.io/argotorg/solc"
1010

1111
if (( $# < 1 || $# > 3 )); then
1212
fail "Usage: $0 <tag/branch> [repo URL] [--no-push]"
@@ -22,7 +22,11 @@ else
2222
publish=true
2323
fi
2424

25-
#docker login
25+
# NOTE: Login to GHCR before running this script with a PAT:
26+
# echo $GHCR_TOKEN | docker login ghcr.io -u USERNAME --password-stdin
27+
#
28+
# Create a classic PAT with write:packages scope only visiting the following url:
29+
# https://github.com/settings/tokens/new?scopes=write:packages
2630

2731
DIR=$(mktemp -d)
2832
(

0 commit comments

Comments
 (0)