apply review feedback

Author: clonker

libyul/AsmJsonImporter.cpp

@@ -207,6 +207,7 @@ Literal AsmJsonImporter::createLiteral(Json const& _node)
 	// import only for inline assembly, no unlimited string literals there
 	lit.value = valueOfLiteral(value, lit.kind, false /* _unlimitedLiteralArgument */);
 
+	yulAssert(validLiteral(lit));
 	return lit;
 }
 

libyul/Utilities.cpp

@@ -180,8 +180,18 @@ bool solidity::yul::validNumberLiteral(solidity::yul::Literal const& _literal)
 	if (!_literal.value.hint())
 		return true;
 
-	auto const repr = *_literal.value.hint();
-	return (isValidDecimal(repr) || isValidHex(repr)) && bigint(repr) <= u256(-1);
+	auto const& repr = *_literal.value.hint();
+
+	if (!isValidDecimal(repr) && !isValidHex(repr))
+		return false;
+
+	if (bigint(repr) > u256(-1))
+		return false;
+
+	if (_literal.value.value() != valueOfLiteral(*_literal.value.hint(), _literal.kind).value())
+		return false;
+
+	return true;
 }
 
 bool solidity::yul::validBoolLiteral(solidity::yul::Literal const& _literal)

libyul/optimiser/BlockHasher.cpp

@@ -210,6 +210,7 @@ void ExpressionHasher::operator()(Literal const& _literal)
 		hash64(std::hash<std::string>{}(_literal.value.builtinStringLiteralValue()));
 	hash64(_literal.type.hash());
 	hash8(static_cast<uint8_t>(_literal.kind));
+	hash8(_literal.value.unlimited());
 }
 
 void ExpressionHasher::operator()(Identifier const& _identifier)

libyul/optimiser/ForLoopConditionIntoBody.cpp

@@ -58,7 +58,7 @@ void ForLoopConditionIntoBody::operator()(ForLoop& _forLoop)
 			Literal {
 				debugData,
 				LiteralKind::Boolean,
-				LiteralValue{true, "true"},
+				LiteralValue{true},
 				m_dialect.boolType
 			}
 		);