Merge pull request #11308 from ethereum/error-cleanup

Remove obsolete Error constructor

Author: axic

liblangutil/Exceptions.h

@@ -122,16 +122,6 @@ class Error: virtual public util::Exception
 		Warning
 	};
 
-	// TODO: remove this
-	Error(
-		ErrorId _errorId,
-		Type _type,
-		SourceLocation const& _location = SourceLocation(),
-		std::string const& _description = std::string()
-	):
-		Error(_errorId, _type, _description, _location)
-	{}
-
 	Error(
 		ErrorId _errorId,
 		Type _type,

test/libsolidity/AnalysisFramework.cpp

@@ -105,8 +105,8 @@ ErrorList AnalysisFramework::filterErrors(ErrorList const& _errorList, bool _inc
 				newError = make_shared<Error>(
 					currentError->errorId(),
 					currentError->type(),
-					location ? *location : SourceLocation(),
-					messagePrefix + " ...."
+					messagePrefix + " ....",
+					location ? *location : SourceLocation()
 				);
 				break;
 			}