-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace direct SNARK with batched SNARK #197
Labels
enhancement
New feature or request
Comments
|
+1 on removing the direct SNARK. it would also allow us to remove a lot of of the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The implementations of the batched SNARKs are should be equivalent to the non-batched versions. We can replace the direct implementation with the batched one using a number of instance = 1.
outer_r
challenge in cases where number of instances = 1.SumcheckEngine
related structs fromppsnark.rs
tosumcheck.rs
RelaxedR1CSSNARK
forbatched_ppsnark::RelaxedR1CSSNARK
andbatched::BatchedRelaxedR1CSSNARK
using vectors of size 1.This should help with maintenance going forward as we will only have to maintain 2 SNARKs rather than 4.
The text was updated successfully, but these errors were encountered: