Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: install basic CI + remove clippy linting or make sure the repo passes it #3

Closed
huitseeker opened this issue Apr 24, 2024 · 0 comments · Fixed by #5
Closed

CI: install basic CI + remove clippy linting or make sure the repo passes it #3

huitseeker opened this issue Apr 24, 2024 · 0 comments · Fixed by #5
Labels

Comments

@huitseeker
Copy link

At the moment, no PR is likely to pass the CI of this repo, because of :

  • a stale rust-toolchain,
  • clippy warnings in many places.

We should modify the repo so that it has basic CI. Important note: the clippy lint needless_borrow is often a false positive in this repo, since the verbose references are there to allow the compiler to infer that many functions are in a const context. I'd advise initially #[allow(...)]-ing it.

@huitseeker huitseeker added the CI label Apr 24, 2024
@huitseeker huitseeker changed the title CI: remove clippy linting or pass it CI: install basic CI + remove clippy linting or make sure the repo passes it Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant