You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #99 we bring in tooling for testing of recursion under docker, without making it default. This issue is about what it would take to make it default:
The default behavior is the activation of the native feature in gnark-ffi/Cargo.toml, which forces those recursion tests to run on the local machine (rather than in Docker).
The Docker behavior not only is non-default, but doesn't work.
We would like to have the following outcomes (only required once #99 is merged, of course):
when a PR that does not modify the Dockerfile is tested, those tests should occur by retrieving the image from a Lurk-Lab registry,
when a PR does modify the Dockerfile is tested, those tests should rebuild the Docker image from file before running, tag it, and then use the environment variable to select that image (by tag) for running tests,
In #99 we bring in tooling for testing of recursion under docker, without making it default. This issue is about what it would take to make it default:
The default behavior is the activation of the
native
feature ingnark-ffi/Cargo.toml
, which forces those recursion tests to run on the local machine (rather than in Docker).The Docker behavior not only is non-default, but doesn't work.
SPHINX_GNARK_IMAGE
) to retrieve the Docker image, and default to an upstream-controlled registry if that variable is unset:https://github.com/lurk-lab/sphinx/blob/bb00d3e1441d769edc8f7a8f717885502e177233/recursion/gnark-ffi/src/ffi/docker.rs
We would like to have the following outcomes (only required once #99 is merged, of course):
The text was updated successfully, but these errors were encountered: