Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for automatic conversion from dict-of-dicts to list-of-dicts #4284

Closed
13 tasks done
ClausHolbechArista opened this issue Jul 30, 2024 · 0 comments · Fixed by #4321, #4320 or #4327
Closed
13 tasks done
Milestone

Comments

@ClausHolbechArista
Copy link
Contributor

ClausHolbechArista commented Jul 30, 2024

Remove support for automatic conversion from dict-of-dicts to list-of-dicts in both eos_designs and eos_cli_config_gen. This should be split into multiple PRs as needed.

eos_designs:

  • Remove convert_types: [dict] from schema
  • Remove convert_dicts() from Python code.
  • Clean up deprecated tests if they are only testing the old dict models.

eos_cli_config_gen:

  • Remove convert_types: [dict] from schema
  • Remove | convert_dicts from Jinja templates.
  • Clean up deprecated tests if they are only testing the old dict models.

General

  • Identify schemas with convert_types: [list] since these may also rely on convert_dicts code.
  • Remove avd_data_conversion_mode from
    • schemas
    • Ansible plugins
    • PyAVD
    • Documentation
  • Update release-notes + porting-guide with this change
  • Clean up schema tooling to longer convert dicts and lists and no longer emit deprecation and conversion warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment