Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output + media_query + transport auto not working properly #1127

Closed
nk-o opened this issue Sep 18, 2016 · 2 comments
Closed

output + media_query + transport auto not working properly #1127

nk-o opened this issue Sep 18, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@nk-o
Copy link

nk-o commented Sep 18, 2016

Issue description:

When I trying to add some css property to specific @media query, Kirki simply put it without using @media. This occurs only when css added without page reload. On this screenshot see how to added property:

screen shot 2016-09-18 at 11 58 00

First property added when I try to change value in customizer (is not correct).
Second property added in php before customizer loaded (is correct).

Version used:

2.3.6

Using theme_mods or options?

theme_mods

Code to reproduce the issue (config + field(s))

Example with typography field, but it's not working properly for all available field types.

Kirki::add_field('nk-theme', array(
    'type' => 'typography',
    'settings' => 'typography_html',
    'label' => esc_attr__('HTML', 'nk-theme'),
    'section' => 'typography',
    'default' => array(
        'font-size' => '14px'
    ),
    'output' => array(
        array(
            'element' => 'html',
            'media_query' => '@media (min-width: 991px)'
        ),
    ),
    'transport' => 'auto'
));
@aristath aristath added the bug label Sep 18, 2016
@aristath aristath added this to the 2.3.7 milestone Sep 18, 2016
@aristath aristath self-assigned this Sep 18, 2016
@aristath aristath modified the milestones: 2.3.7, 2.3.8 Oct 21, 2016
@aristath aristath modified the milestones: 2.3.8, 2.4.0 Dec 10, 2016
@aristath aristath modified the milestones: 2.4.0, 3.0 Mar 28, 2017
@aristath
Copy link
Contributor

Closing as duplicate of #1184

@aristath
Copy link
Contributor

Fixed in 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants