-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webfonts.php #1303
Comments
Done. |
Thanks a lot, @aristath. |
Should be ok now 👍 |
Just tested it. Seems that Google Fonts are not enqueued on the front-end. The backend (customizer view) works fine though. |
Reopened, I'll check into it later today. |
@hellor0bot by "Not enqueued" what exactly do you mean? As recommended on https://modpagespeed.com/doc/filter-css-inline-google-fonts googlefonts should be added inline instead of enqueued. It's 1 less request on the browser, and it just makes sense... So in version 3 we attempt to get the contents of the googlefonts URL (which is built just like before). If the body of that request is retrieved successfully, then it is added to the kirki styles (and slightly minified too). So... no matter how the code looks, do the fonts work? Can you see the selected fonts properly rendered in the frontend? |
Sorry, I can't test it again right at the moment (reverted to an older develop branch), but the Google Fonts didn't work on the front end (were not rendered). |
How about update in wp.org repository (for us, the mortals ... :) ) ? |
@Micemade 3.0 is close, patience... 😄 |
Issue description:
The current webfonts.php file is outdated.
Could you please update it, so that it includes the latest Google Fonts?
Thank you!
Version used:
Develop branch.
The text was updated successfully, but these errors were encountered: