Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Global libraryPath #10199

Closed
ariya opened this issue Aug 22, 2011 · 3 comments
Closed

Global libraryPath #10199

ariya opened this issue Aug 22, 2011 · 3 comments

Comments

@ariya
Copy link
Owner

ariya commented Aug 22, 2011

roejame...@gmail.com commented:

A type of global libraryPath that will link pages libraryPath's with the main phantom libraryPath.

Current ideas:

1

"It seems as if libraryPath should be global. If I change libraryPath
using phantom.libraryPath, then use page.injectJs, I'd expect it to
just work from the libraryPath I set in phantom.libraryPath.

I can see in some usecases that having a separate page.libraryPath
could be useful. If so, then we could go for a hybrid approach then,
searching phantom.libraryPath first, then the page.libraryPath. This
is probably the best approach in my opinion."

2

"As for path priority, I think it might be better to search from smallest to largest scope (i.e., page first, then phantom), so that it may be overridden.

I can imagine an approach similar to "export PATH" in .bashrc where we just copy the phantom library path when a new page is created. The page could then do what it would after that (as in a terminal session)."

Something similar to ideas expressed in #2 sound ideal, which would be a hybrid approach utilizing the phantom.libraryPath and page.libraryPath.

This is related to issue 152 (CommonJS modules) and issue 198 (multiple libraryPaths)

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #199.
🌟   2 people had starred this issue at the time of migration.

@execjosh
Copy link
Contributor

buildj...@gmail.com commented:

This could also be read from an environment variable. Maybe "PHANTOMJS_LIBPATH" or something like that.

(I moved this comment from issue 198 to this issue)

@execjosh
Copy link
Contributor

execjosh commented Feb 5, 2012

@ariya
Copy link
Owner Author

ariya commented Dec 25, 2019

Due to our very limited maintenance capacity (see #14541 for more details), we need to prioritize our development focus on other tasks. Therefore, this issue will be closed. In the future, if we see the need to attend to this issue again, then it will be reopened.
Thank you for your contribution!

@ariya ariya closed this as completed Dec 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants