Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make chunk size configurable #14

Open
me21 opened this issue Apr 20, 2023 · 1 comment
Open

Make chunk size configurable #14

me21 opened this issue Apr 20, 2023 · 1 comment

Comments

@me21
Copy link

me21 commented Apr 20, 2023

Currently the code reads files by 8 Kb chunks:

python-zipstream/zipstream/__init__.py

Line 310 in 961886f

buf = fp.read(1024 * 8)

Would it be beneficial to make it configurable?
@arjan-s
Copy link
Owner

arjan-s commented Apr 25, 2023

To be honest, I don't know. The current code was already there when I forked the repo, so I'm not sure why this size was chosen. If you or anyone else cares about making this configurable, I'd be happy to accept a PR and make a new release for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@me21 @arjan-s