Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser.urlbar.sponsoredTopSites #1203

Closed
Onfroygmx opened this issue Jul 5, 2021 · 4 comments
Closed

browser.urlbar.sponsoredTopSites #1203

Onfroygmx opened this issue Jul 5, 2021 · 4 comments

Comments

@Onfroygmx
Copy link

Hello,

I don't know the impact and since it is here, but I don't like this setting:
browser.newtabpage.activity-stream.showSponsoredTopSites
default to true.
sponsored
Previously this was your setting:
user_pref("browser.newtabpage.activity-stream.showSponsored", false);

Onf.

@Thorin-Oakenpants
Copy link
Contributor

Thorin-Oakenpants commented Jul 5, 2021

Previously this was your setting:

It has never been in the arkenfox user.js

It was added to Firefox in FF83+, see #1061

  • ignored by me: I'm the only person who does changes: earthlng provides diffs and points things out if they he thinks I missed anything (which is super rare), and no-one else piped up
  • arkenfox disables start and newtab using Activity Stream - see 0102
  • also see 0105: disable Activity Stream stuff (AS)
    • **NOT LISTING ALL OF THESE: USE THE PREFERENCES UI**

  • sponsored shortcuts being collected and stored would be the same for everyone, at least by region or language or something: like snippets, or safe browsing updates etc - everyone gets them, it's not a threat
    • IDK if they are retrieved or not if AS is never shown, and IDCare
    • IDK if the links themselves contain a referal, but again, I doubt it's anything more than a marketing id to gauge success: not trackable or individually identifiable
    • not really interested in looking at it TBH (see the other points) and I can do without the maintenance aspect of the constantly changing AS

The parent item is browser.newtabpage.activity-stream.feeds.topsites , and maybe I got that confused with browser.newtabpage.activity-stream.feeds.section.topstories which now seems to be Pocket related, which confuses me what with browser.newtabpage.activity-stream.section.highlights.includePocket .. which is why I can't be bothered with AS stuff.

I'll @earthlng to see if he thinks we should add this. I get that despite us setting the start and newtab pages to not use AS, some people like it, so maybe it could go under the personal 5000s section (AFAICT this is not a tracking/privacy/fingerprinting/ or security issue)

@Onfroygmx
Copy link
Author

Onfroygmx commented Jul 5, 2021

I might seem crazy but I see it in the user.js:
image

@Thorin-Oakenpants
Copy link
Contributor

you highlighted the child checkbox called "Sponsored shortcuts" and your first sentence says

but I don't like this setting: browser.newtabpage.activity-stream.showSponsoredTopSites default to true.

browser.newtabpage.activity-stream.showSponsoredTopSites is the correct pref that controls the child checkbox. This is not the same as browser.newtabpage.activity-stream.showSponsored

@Thorin-Oakenpants
Copy link
Contributor

The UI for it was added in FF87. It "fits" this description, so I'll just add it there

  • 0105c: disable Activity Stream Top Stories, Pocket-based and/or sponsored content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants