-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should privacy.spoof_english be added? [A: nope, it is a runtime pref and not everyone uses en-US] #1314
Comments
spoof_english (if prompted and accepted) does two things
spoof_english is redundant |
If |
It doesn't matter about the UI. - RFP doesn't have any UI presence. It is redundant from a functional FPing standpoint which is all that matters |
Yes, it matters. If you have:
...and you open that menu option, even if you click Cancel, then |
There is no restriction on users changing settings or prefs per session. A user.js sets (resets) them on a session start. This is no different to a Tor Browser user doing the exact same thing It is also problematic to set it and expose spoof_english via prefs, or it was and maybe needs revisiting
I am using an en-US build. RFP is enabled but does not trigger any spoof_prompt because my build starts with
Non RFP users we don't care. For RFP users, on an in other words you are talking very edge case the checkbox
This was all discussed four+ years ago 🔻 FF59
also relevant is 1447592 FF61+ Don't reset privacy.spoof_english when RFP is flipped to false
Also, I expect use_us_english to be deprecated soon and RFP to just automatically apply the correct locale for any language used (and the checkbox option to be removed), and for spoof_english to simply become a prompt to use the most common language I am not convinced in any way that we need to add spoof_english and complicate matters |
re-opening to satisfy my curiosity and to remind me to check a few things |
in an en-gb release, fresh profile, I enabled RFP and then set
got the same result with a de-DE release, which surprise me cause the UI of the browser is german but all checks on TZP are fine. also, when enabling RFP in this german release I was prompted to change my language to english immediately. edit: I tested everything manually with about:config changes. I should try with a user.js. ok the current setup is the only one that works in the context of a user.js, I can use whatever UI I want without leaking. |
use this page - https://arkenfox.github.io/TZP/tests/formatting.html - it's locale/language only and ignores timezones no, we need to set the two prefs, because
When RFP is enabled the pref is reflected in the UI settings (otherwise the UI bit does not show) spoof_english is meant to be runtime, it does things when triggered, such as on first HTTP* load. There's also something going on with when you flip RFP off (or maybe I am thinking that when RFP is flipped off, a patch was added to not reset spoof_english? - I can't remember) - anyway it's best left as runtime (see you already had issues trying to use it via user.js) On Tor Browser en-US (they only put out the one Sure, if we set all three prefs from user.js (assuming spoof_english sticks), then big fucking deal. TB don't care about it. And I also don't know of the ramifications/side-effects and doing this and not letting runtime fully run it's course In a non |
tl;dr - NO! SPOOF ENGLISH SHOULD BE LEFT ALONE |
I'm sold on the final result but one more thing.
but me said:
and as you can see everything was shown as |
Hi,
When
privacy.resistFingerprinting
=true
, a new option becomes available in:General > Choose your preferred language for displaying pages > Choose > Request English versions of web pages for enhanced privacy
This option changes three config settings:
intl.accept_languages
=en-US, en
javascript.use_us_english_locale
=true
privacy.spoof_english
=2
However, it seems user.js only considers the first two config settings.
Shouldn't
privacy.spoof_english
also be added?The text was updated successfully, but these errors were encountered: