Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

[condition] uniformize attribute condition with resource filter #463

Open
nriss opened this issue Dec 2, 2020 · 0 comments
Open

[condition] uniformize attribute condition with resource filter #463

nriss opened this issue Dec 2, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@nriss
Copy link
Contributor

nriss commented Dec 2, 2020

Description

It would be great to uniformize the operators between attribute condition and resource filter.

Question:
Is it better to keep or to remove include / exclude functionality ?

In my opinion, the system can be only based on inclusion criteria, and it would be easier to understand. We want to create ressource / add attribute only if the condition matches.
I don't think we will lose any functionality, we just have to use the opposite operator instead of exclude.

  • Using like <> instead of == would make the exclude choice useless.
@nriss nriss added the enhancement New feature or request label Dec 2, 2020
@Jasopaum Jasopaum self-assigned this Dec 2, 2020
@nriss nriss changed the title [condition] add <> functionality [condition] uniformize with resource filter Dec 2, 2020
@Jasopaum Jasopaum removed their assignment Dec 2, 2020
@nriss nriss changed the title [condition] uniformize with resource filter [condition] uniformize attribute condition with resource filter Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants