-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use in_place
suffix for BigInteger
operations
#781
Comments
Yes, this would be great! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the whole codebase, there is a standard which is to include the suffix
in_place
on operations which modify the value passed as a mutable parameter. For example here:algebra/ec/src/models/bn/g2.rs
Lines 53 to 77 in cc2ad8c
We know from the function name that the
self
mutable will be modified.However similar operations are performed in the
BigInteger
trait like:algebra/ff/src/biginteger/mod.rs
Line 1062 in cc2ad8c
or
algebra/ff/src/biginteger/mod.rs
Line 1037 in cc2ad8c
without including the
in_place
suffix. For readability and consistency, it could be nice to include this suffix for all theBigInteger
operations concerned by this type of logic.The text was updated successfully, but these errors were encountered: