Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocummented panics from asserts in code #908

Open
piohei opened this issue Dec 18, 2024 · 0 comments
Open

Undocummented panics from asserts in code #908

piohei opened this issue Dec 18, 2024 · 0 comments

Comments

@piohei
Copy link

piohei commented Dec 18, 2024

Hi!
Recently my team updated some library that underneath is using ark-ec. That causes our app to panic because of some malformed input. It let me down to that part of code but I see that pattern (asserts on input) is widely used. Have you considered returning Result instead of just panic? What is your preference here? If you still want to panic it would be nice to document it.
I would be eager to help with changes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant