Deprecate WIREGUARD?

[EvilOlaf]

Which feature would you like to have?

https://github.com/search?q=repo%3Aarmbian%2Fbuild%20wireguard-tools&type=code
It seems like wireguard-tools is already in the list of common packages and WIREGUARD=yes basically installs this package.
So besides using it on a minimal image there is no real use for it. So maybe deprecate WIREGUARD entirely now?

Funding

• I am willing to cover expenses

[github-actions]

Jira ticket: AR-2498

[igorpecovnik]

So maybe deprecate WIREGUARD entirely now?

Probably best. And deal with this here https://github.com/armbian/configng

[EvilOlaf]

There are a handful of board config files with WIREGUARD=no but I assume this line does not do anything since the wireguard-tools package is part of the common list.
Besides those removal is necessary here

build/lib/functions/configuration/main-config.sh

Line 266 in 5e8d48c

[[ -z $WIREGUARD ]] && WIREGUARD="yes"

and here

build/lib/functions/rootfs/distro-agnostic.sh

Line 357 in 5e8d48c

# install wireguard tools

And that should be pretty much it.

[rpardini]

Yeah, it was already a bit not-really-used since armbian-next. Having wireguard nowadays is a question of kernel .config and some userspace nice to haves....