Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty{} values from the Delim rule should appear as nil nodes in the correct branch, not in @empty #44

Open
ghost opened this issue Feb 28, 2020 · 1 comment
Labels
P2 Low priority

Comments

@ghost
Copy link

ghost commented Feb 28, 2020

I'm going to merge this as is, I don't know if it is possible to determine the branch name where the nil values should be added to. will create an issue to resolve this later

Originally posted by @anz-gordonj7 in #43 (comment)

@marcelocantos
Copy link
Contributor

marcelocantos commented Mar 1, 2020

They should go into the same branch as the lhs of the : operator. This might be possible only if the top node of the lhs is a Named or Rule. I think this needs to be required for all < and > variants in order to build the binary tree structure correctly. Perhaps it also applies to , variants.

@ChloePlanet ChloePlanet added the P2 Low priority label Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority
Projects
None yet
Development

No branches or pull requests

2 participants