Skip to content

Remove unimplemented internal functions. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noughtmare opened this issue Nov 5, 2019 · 4 comments
Closed

Remove unimplemented internal functions. #14

noughtmare opened this issue Nov 5, 2019 · 4 comments

Comments

@noughtmare
Copy link

Running cabal test fails because the linker can't find these functions:

In Image.hsc:

  • af_iterative_deconv
  • af_iverse_deconv

In LAPACK.hsc:

  • af_pinverse

In Signal.hsc:

  • af_approx1_uniform
  • af_approx2_uniform

Should these functions be removed?

@dmjio
Copy link
Member

dmjio commented Nov 5, 2019

@noughtmare can you confirm you're using 3.6.4. If so, then yes I can make a PR to comment them out. They might have been implemented from building off of master.

@noughtmare
Copy link
Author

@dmjio Yes, I'm using 3.6.4. Interestingly, there are some comments in the higher level *.hs files about this:

-- Not implemented in /3.6.4/
and
-- DMJ: did this get removed? Can't find in latest docs

@dmjio
Copy link
Member

dmjio commented Nov 5, 2019

fftConvolve1 was commented out. I'll update the others as well. Thanks for looking into this.

@dmjio
Copy link
Member

dmjio commented Nov 5, 2019

#17

@dmjio dmjio closed this as completed Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants