Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram example is incorrect #81

Closed
bkloppenborg opened this issue Mar 3, 2016 · 2 comments
Closed

histogram example is incorrect #81

bkloppenborg opened this issue Mar 3, 2016 · 2 comments
Assignees
Milestone

Comments

@bkloppenborg
Copy link

There are (at least) two issues here with the histogram example:

  1. The Perlin distribution should result in a Gaussian-like distribution of noise, whereas the histogram does not display anything remotely close to this, and
  2. There appears to be a plotting error wherein every 3n and 4n values are near zero in the histogram.

The Perlin distribution used in the histograms should result in a Gaussian-like noise distribution; however, in the examples, it is anything but Gaussian:

5a349626-e132-11e5-9654-ed3c3b8d0596

This is even more apparent if one increases the number of bins to around 100:

screenshot from 2016-03-03 13-08-41

Also, there appears to be an odd pattern wherein every 3rd and 4th value on the x-axis is near zero.

@9prady9 9prady9 added this to the 1.0.0 milestone Mar 4, 2016
@9prady9 9prady9 self-assigned this Mar 4, 2016
@9prady9
Copy link
Member

9prady9 commented Mar 4, 2016

@bkloppenborg and @syurkevi I fixed histogram example in api_changes branch. Here are the images.

screenshot from 2016-03-04 10-59-39
screenshot from 2016-03-04 10-59-41
screenshot from 2016-03-04 10-59-42
screenshot from 2016-03-04 10-59-43

@9prady9
Copy link
Member

9prady9 commented Mar 4, 2016

I will do similar code changes in CUDA and OpenCL examples.

FYI - These are only changes in example code, the rendering code doesn't have any bugs.

@9prady9 9prady9 mentioned this issue Mar 4, 2016
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants