Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revalidate Readme's module config #2207

Closed
aballano opened this issue Aug 25, 2020 · 4 comments
Closed

Revalidate Readme's module config #2207

aballano opened this issue Aug 25, 2020 · 4 comments

Comments

@aballano
Copy link
Member

This might come handy to save the users from self-importing this themselves, although I'm wondering if this guide in the arrow readme was then accurate to the previous state 🤔

I think we should check that document and validate if it's correct (for example arrow-optics doesn't seem to expose core, yet core doesn't appear in the readme for optics)

Originally posted by @aballano in arrow-kt/arrow-core#224 (comment)

After this PR is merged we should revisit the module guide to validate the config and add/remove modules if necessary

@aballano aballano self-assigned this Aug 25, 2020
@rachelcarmena
Copy link
Member

Awesome idea @aballano 🙌 Here the dependencies graph before the split: arrow-dependencies

@rachelcarmena
Copy link
Member

Pending improvement after arrow-kt/arrow-core#224: Arrow Optics should add Kotlin Standard library to compile so it will be able to be removed from Arrow Annotations as exported to consumers.

@aballano aballano removed their assignment Jan 8, 2022
@i-walker
Copy link
Member

i-walker commented Mar 11, 2022

Thanks @aballano, since Arrow Optics exposes Arrow Core there is no need to add Arrow Core in the build explicitly.
We're updating the Set up Documentation and providing Repositories on top #2685
Like for Multiplatform https://github.com/arrow-kt/Arrow-MPP-Template, Maven https://github.com/arrow-kt/Arrow-Maven-Template, JVM with Gradle https://github.com/arrow-kt/Arrow-JVM-Template and JS https://github.com/arrow-kt/Arrow-JS-Template

@nomisRev
Copy link
Member

nomisRev commented Apr 5, 2023

@i-walker @aballano can this issue be closed?

@aballano aballano closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants