Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

current sources complain with "tdlib version 1.7.9 is required" #169

Open
itt533 opened this issue Sep 2, 2022 · 14 comments
Open

current sources complain with "tdlib version 1.7.9 is required" #169

itt533 opened this issue Sep 2, 2022 · 14 comments

Comments

@itt533
Copy link

itt533 commented Sep 2, 2022

i downloaded the current sources of tdlib-purple, and at cmake command prompt i get:

CMake Error at CMakeLists.txt:11 (message):
tdlib version 1.7.9 is required

(version found: 1.8.4)

my command is :
cd tdlib-purple-master
mkdir -p build
cd build
cmake
-DTd_DIR=/usr/lib/cmake/Td ..
-DTgvoip_LIBRARIES="tgvoip;opus"

@BenWiederhake
Copy link
Contributor

Well, if tdlib version 1.7.9 is required, then why are you trying to build with version 1.8.4 instead?

@itt533
Copy link
Author

itt533 commented Sep 3, 2022

yes it looks like i'm not serious, but the fact that it is requiring one exact version surprised me and also aur.archlinux.org is currently using v. 1.8.0. They are actually using the patch from the pull 154 to patch tdlib-purple v. 0.7.9.rxxx.

@BenWiederhake
Copy link
Contributor

BenWiederhake commented Sep 3, 2022

I'm very sorry to hear that aur.archlinux.org is using an unsupported combination of versions, but I cannot change that. You might want to use a supported combination, for example:

tdlib-purple td works?
0.8.1 or master 1.7.9 Yes, like the build script says
#159 (or #154 if you insist) 1.8.0 Yes, that's what I'm using
??? 1.8.4 No, at least not to my knowledge

Of course, you're very welcome to update tdlib-purple to deal with td 1.8.4, I believe this would make many people happy.

EDIT: I typo'd the td version number, it's now fixed.

@itt533
Copy link
Author

itt533 commented Sep 5, 2022

ok i tried and it worked, with #159 it's better as it downloads some of the history. But I'm just discovering that despite the effort of telegram to offer a fully open API to allow us making our own clients there's a long way to go with this plugin to be descent.

@BenWiederhake
Copy link
Contributor

Like I said, you're very welcome to update tdlib-purple to deal with the newest td, I believe this would make many people happy. The only thing missing is one person who actually implements it.

@itt533
Copy link
Author

itt533 commented Sep 17, 2022

i feel fine about that but is it worth it? I'd prefer to do it from scratch since the current version is not doing a lot. How long time the current version of pidgin is going to live?

@BenWiederhake
Copy link
Contributor

So what is your question here? If you don't wanna use it, then don't use it.

@itt533
Copy link
Author

itt533 commented Sep 18, 2022

i'm serious, is the current version of pidgin going to live long? I read in the telegram channel of tblib-purple that it lacks flexibility to implement all the features that telegram offers. The work of developing this plugin seems very big.

@BenWiederhake
Copy link
Contributor

I'm a pidgin user, and this is the repository for a plugin particularly for pidgin, which I still use and sometimes make a few edits to keep the lights on. If that doesn't answer your question, then I don't know what will.

@asctime
Copy link

asctime commented Jan 9, 2023

Wow this sucks. I hope that proper packaging and build documentation can be restored to this project. bleh...

@BenWiederhake
Copy link
Contributor

You're welcome to improve the situation instead of complaining.

@asctime
Copy link

asctime commented Jan 9, 2023

At the risk of helping someone who can't be helped, I'll clarify:

  1. If your project requires very specific dependencies then it should be on the front page of your project in BOLD type - it shouldn't be something "discovered" half way into a build.
  2. Working links to hard to find package versions that WILL compile should be provided.
  3. If your releases are necessarily married to specific dependency versions then it would probably be a good idea to even name them that way.
  4. Proper forks should be offered for upstream compatibility versions (1.8.0 fork etc) not just dig through your patches and hope you did it right.
    One more thing. Honestly, any package that changes it's public API every single minor release probably isn't worth working on to begin with..

@heeplr
Copy link

heeplr commented Mar 30, 2024

I think the main problem here is that there doesn't seem to be an official 1.7.9 release from upstream. All I could find was the github tags.
Where could I get the 1.7.9 source?

@BenWiederhake
Copy link
Contributor

You could just use this script / repo to do everything in a single command, or if you want to do it the hard way: commit 1d1bc07eded7d3ee7df7c567e008bbf926cba081.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants