-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package 4.0.4 #566
Comments
I see youre actively working on some hard packaging problems. I am attending PyCon and I think this would be something I'd like to work on during the sprints. I'd have to learn a lot but it would be worth it. Are you at PyCon? Tweet me @scresante |
@scresante Currently I have working windows builds and finally got a way to build the OSX Qt version and package it. I had some issues with using the existing package.py for the supported linux packages last time I tried to package them and haven't quite got through them yet. I am not at PyCon. |
Just a general progress update here:
|
It's been many years since I interacted with a Mac OS system as a developer. I don't remember. |
@arsenetar I currently maintain the PKGBUILD for the Arch Linux User Repository (AUR). Packaging for it could be already be considered mostly done already? I'm currently working on upgrading to 4.0.4. I'm still pulling some dependencies with However, I noticed the hscommon is empty in the source release tarball that I use for the package (qtlib also). Is this intentional or a mistake? We still require dependencies from this base package. |
@glubsy The source tarball that is currently in this release is the automatically created one from github which does not contain the contents of the submodules. I have uploaded a complete one now as well: https://github.com/arsenetar/dupeguru/releases/download/4.0.4/dupeguru-src-4.0.4_RC.tar.gz (The RC is mainly just to indicate there may be some changes to scripts to accomplish packaging all versions). |
@arsenetar thanks for taking the time to set up the complete tarball. The Arch PKGBUILD works just fine now. Also thanks for working on this release. I meant to join the endeavour before but I got pulled into other projects. Still might attempt to contribute in the future. ;) |
ho do i get hsaudiotag on ubuntu? it seems missing in the phyton3 package. |
@Mannshoch you should be able to get it with |
pip3 seems not installed on my computer but after install that also it worked. |
@arsenetar, any updates on the Mac release? |
@ryanpcmcquen, I have actually got the application built and running on OSX with the Qt version which I consider experimental as I am not sure if there will be any incompatibilities. The user interfaces has a few oddities but is functional and scanning seems to work. The Cocoa UI version has had some issues with the packaging scripts which I have not completely resolved. I believe I might have a solution but have not had a chance to test it out. On some level this has been mostly stalled out since mid May since I have been quite busy outside of this project. I will see if I can finish up packaging the Qt version in the next week as that seemed to be ready to go, just wanted to validate some of the functionality a bit more. I will also try out my solution for the Cocoa version to determine what the next steps are for that package. (The Cocoa version thus far has been a bit of a time sink for me due to the packaging issues when I have had time to work on this project.) I do plan to get the Cocoa packaging figured out for this release and at least one more, but I am strongly considering dropping the Cocoa version and just doing the Qt version for OSX instead if that proves to work. TLDR: OSX packaging has had some issues and life has been busy. Will attempt to release Qt version within a week, and possibly Cocoa if things go well. |
Updated the release to point to AUR page for Arch Linux package. |
@arsenetar, thank you for all your work! I would be happy with any version. 👍 Sounds like Qt is the way to go. 😸 |
Just an update since I don't have the OSX Qt version released yet, having issues with signing the application so that OSX security will let the application run once downloaded. I thought I could get through this but it has been a rabbit-hole style problem of issues. |
@arsenetar, can't it be run without signing by right clicking the |
@ryanpcmcquen I did not have luck with that and OSX 10.14, you can disable Gatekeeper it seems then it works or change an attribute on the file via the command line after download. I figured both those options were non-ideal. I think I had tried right clicking earlier on and was unsuccessful, since it was an unidentified developer. I can give it a try again, I saw some information to support it should have worked that way, but didn't when I tried it out. |
@arsenetar, that is unfortunate! |
No longer going to try to package an .rpm this time around as there have been enough issues getting the rest of the packages made. |
FWIW, Apple officially recommends that if you are going to use a separate language interpreter like Python, that you incorporate the interpreter itself (and any related dependencies, like libraries) into your package, and not depend upon the OS version, if any. This pretty much eliminates all wrong-version-of-Python issues, and avoids stepping on some of the security landmines. With this formula, you can write an App Store app (for macOS or iOS or tvOS) mostly in Python or whatever. The myth that you can't use Python to build an app-store app is just that -- a myth. It should also ultimately simplify packaging -- everything goes directly into the project, and the project puts everything into into the resulting app. Compiled interpreters become signed "auxiliary executables". ".py" files become app resources. With that observation I have exhausted my knowledge of Python. |
For those of you interested in trying it out, I got an unsigned build of the OSX versions made today which will work in Catalina (10.15). I need to try to verify them a bit more before posting them in the release. Since these files are not signed with a developer cert, you will have to allow them in System Preferences > Security and Privacy. The Qt version does not use the dark theme. Files: |
Some short test with this build dupeGuru_osx_cocoa_4.0.4_RC1: dupeGuru_osx_qt_4.0.4_RC1:
I like that you merge Preferences... in one window and add tab for results, but I can't find a way to switch between them with keyboard. @arsenetar Thank you for maintaining this nice app and I hope that you will find solution for all macOS related problems |
@emilbar Do you have the crash information for the cocoa version? That would be helpful in determining why it is not running. I had it running on 10.15 and it seemed to work so I wonder if this is something that is not compatible with 10.14 from the build. The qt version is just the windows/linux version built for OSX so it will have some differences from the 4.0.3 version. I am really just trying this out starting in 4.0.4 to see if I can reduce the amount of UI development.
Thanks for providing the feedback. |
Looks like there might be an issue with the embedded version of python on the cocoa version. I am still looking into it but that seems to be likely. |
@emilbar Ok, so it looks like the python I had used to package the application had a dupeGuru_osx_cocoa_4.0.4-RC2.zip This one is also signed and notarized so you should not perform the extra steps to let it run. |
@arsenetar Same crashes with this version. Iam sending you log file. I hope that will help you. Iam not a programmer. Just basic knowledge with javascript for writing mini scripts for automating Adobe Indesign and some understanding of coding. So maybe sometimes i will ask stupid question:) I dont care much about naming menus or if it is qt version except for QucikLook support. Do you intend to include this on mac version? And sorry for my english, its not my primary language. |
@emilbar Thanks for the crash report. That is useful, I have not figured out why you see that issue and I don't with the build. The application packages its own version of python3 as an embedded framework so the python difference between Mojave and Catalina should not be an issue. I am probably going to need some more feedback to help determine the issue, but will continue looking into it. @ryanpcmcquen would you be able to try the new RC2 release of the cocoa version and let me know if you have any issues with it? |
@arsenetar, it will not launch for me. |
@arsenetar, here is what I get when I launch from the command line:
|
Thanks @ryanpcmcquen, this additional information is helpful. Just for reference what version of OSX are you running? |
@arsenetar: |
@ryanpcmcquen @emilbar Just a quick update, the information you guys have provided has helped me get closer to figuring out what might be going on here. Unfortunately, I cannot reproduce the issue in my build environment. This has made identifying the exact cause a bit harder. I have managed to rule a few possibilities out. I am currently working on getting a separate test environment setup to help find the exact cause of the issue. I also have found a few issues in the QT version of the application (for OSX), which I would like to fix before finalizing that one for release. |
Seeing the same. RC1 works (but crashes on large libraries), while RC2 won't launch. |
I am reporting the same as fuzzy76. I've attached an error log file here. It's an error log from Apple, not from DupeGuru. |
On Catalina 10.15.5 neither RC1 nor RC2 launches. |
@SeaCelo does the Qt version run? https://github.com/arsenetar/dupeguru/files/4013495/dupeGuru_osx_qt_4.0.4_RC1.zip |
Yes. I'm running it now and seems to launch and is analyzing picture contents |
FYI, while it launches and "runs", it does not complete. Seems to get stuck at: |
Update: I deleted all preferences and ran the app again (QT). Works. Not sure why it wants access to paths like these, though:
|
Running it again and crashing. From console: |
@SeaCelo Thanks for the updates, with regards to the path access, I am not aware of a reason why it would be accessing that path unless it was part of a directory added to look in. I can look into this a bit more. As for the crash report good to have. I think it is best to attach those as a text file to the post so it does not scroll the conversation so much. |
@arsenetar Fixed the long post. Sorry. I'm happy to test and send crash reports if needed. Right now, it just doesn't work and I don't know why it sometimes runs or not. |
@SeaCelo I'll be trying to reproduce the path behavior and see if there is something I can Identify with the crash. I should have a new version of the non-Qt OSX version up soon, as I think I have figured out the issue with that version but need to do some testing myself to validate it. I'll post an update here once I learn something or have a new version to try. |
In case this is helpful, simply launching 4.0.4 QT shows this set of messages in my Console output: You'll note this group of errors:
|
Closing this #753 will take over any remaining things that would carry over. |
Package .debPackage .rpm (maybe)The text was updated successfully, but these errors were encountered: