Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(async): add test isEverSettled after abort #985

Closed
wants to merge 1 commit into from

Conversation

skhrv
Copy link
Contributor

@skhrv skhrv commented Nov 29, 2024

 FAIL  src/withStatusesAtom.test.ts > isEverSettled after abort
AssertionError: expected { isPending: true, …(6) } to deeply equal { isPending: true, …(6) }

- Expected
+ Received

  Object {
    "isEverPending": true,
-   "isEverSettled": true,
+   "isEverSettled": false,
    "isFirstPending": false,
    "isFulfilled": false,
    "isPending": true,
    "isRejected": false,
    "isSettled": false,
  }

 ❯ src/withStatusesAtom.test.ts:225:43
    223|   fetchData(ctx)
    224|   await null
    225|   expect(ctx.get(fetchData.statusesAtom)).toEqual({
       |                                           ^
    226|     isPending: true,
    227|     isFulfilled: false,

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

Copy link

stackblitz bot commented Nov 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reatom ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 2:36pm

@artalar
Copy link
Owner

artalar commented Dec 11, 2024

Fixed in 85e60ef

@artalar artalar closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants