Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category on traits #1790

Closed
wants to merge 3 commits into from
Closed

Conversation

WebEtSolutions
Copy link
Contributor

Hi !

We have added the possibility to make traits under categories like blocks. When you create a trait you can add a property like this

label: 'My trait', type: 'text', category: { id: 'general', label: 'General', }

And the "My trait" trait will be make under the "General" category.

category propertie is optional and it's like the block category. (string or object)

@artf
Copy link
Member

artf commented Feb 16, 2019

Sorry guys, I really appreciate your efforts, but I can't accept this PR.
This is just a big copy paste from the BlockManager module, even with some logic IMHO that doesn't make sense to have (like private and public collections, it's ok for Blocks but not for Traits).
First of all, the correct approach for any PR (especially big like your) on OSS projects it should be to ask the team (by opening an issue) if this is something we need to add to the core. Then probably we would tell you ok and we would share some guidelines about the implementation (like creating an abstract module for categories and refactoring the BlockManager code).

@lock
Copy link

lock bot commented Feb 16, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Feb 16, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants