support long running sessions

[rafaelri]

Hi all, I've noticed on android version that it isn't possible to have long running sessions since the logs collection on AbstractSession and statistics collection on FFmpegSession are all append only. I'd like to roll out a simple clearLogs and clearStatistics on AbstractSession and FFmpegSession to allow for long running sessions. Can I submit a PR for it? I tried but it isn't allowed.

[tanersener]

Yes, you can submit a PR.

I don't remember putting a restriction on PRs. If you share the screenshot/error you see I can try to understand where it is coming from.

[rafaelri]

I was getting OOMs after 2 days running. A heapdump shown that I had lots of Log and Statistics entries in the heap. When I tried to push to a different branch on your repo I got a denied error. The change is dead simple (I could have envisioned a more elegant solution but this will suffice for now) I added a clearLogs to AbstractSession and clearStatistics to FFmpegSession.

[tanersener]

When I tried to push to a different branch on your repo I got a denied error.

Which branch was the target of your PR? main branch is protected but you are allowed to create a PR against the development. That's the branch where we work on the new features.

[rafaelri]

I've created a branch locally from development branch but got the same result when trying to push my local branch to create the PR.

[tanersener]

You have a fork right? If pushing your local branch returns an error then something must be wrong about your fork perms.