You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.
If there's a SVG icon inside icons, this package fails with the following error:
It was not possible to read 'src/icons/some.svg'.
This happens because we are using jimp to resize the images but it doesn't support SVGs. And it shouldn't because SVGs are scalable by nature, thus they don't need to be resampled. My suggestion is to detect SVGs via the type (and fallback to extension) and skip jimp if the detection identified a SVG.
Do you agree with this? If so, I will make a PR to implement this strategy.
The text was updated successfully, but these errors were encountered:
Indeed, jimp can process png, jpg and bmp so it would be nice to check if the file matchs one of these extensions (and maybe log a warning if you want to resize an unsupported image file extension like .webp)
If there's a SVG icon inside
icons
, this package fails with the following error:This happens because we are using
jimp
to resize the images but it doesn't support SVGs. And it shouldn't because SVGs are scalable by nature, thus they don't need to be resampled. My suggestion is to detect SVGs via thetype
(and fallback to extension) and skipjimp
if the detection identified a SVG.Do you agree with this? If so, I will make a PR to implement this strategy.
The text was updated successfully, but these errors were encountered: