Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using react-semantic-ui-datepicker with formik-semantic-ui-react #707

Closed
phurichpusapanich opened this issue Jan 12, 2022 · 3 comments · Fixed by #708
Closed

Using react-semantic-ui-datepicker with formik-semantic-ui-react #707

phurichpusapanich opened this issue Jan 12, 2022 · 3 comments · Fixed by #708

Comments

@phurichpusapanich
Copy link

phurichpusapanich commented Jan 12, 2022

Hello,

I am working on a form project using react-semantic-date-picker with formik-semantic-ui-react + yup validation.

I notice that, when i use the Form component from formik-semantic-ui-react to wrap SemanticDatePicker, the error style for SemanticDatePicker is not fully shown. From this sandbox, I learn that I can use html form to solve this problem but I will be losing the styles I get from Form

You can have a look here for my implementation.

In there, you can see that the error only apply to the font but not the entire Input.

Would there be any alternatives to this?

Thanks,

@github-actions
Copy link

🎉 This issue has been resolved in version 2.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arthurdenner
Copy link
Owner

arthurdenner commented Jan 13, 2022

Hi @phurichpusapanich-itsmy! 👋🏽

Thank you very much for reporting this!
There's nothing wrong with your code.

I did some debugging here and noticed that the error must be passed to Form.Field when Form is used.
This applies to semantic-ui-react as well, it's something I missed 😢

It has been fixed in #708 and released on 2.15.1.
I forked your sandbox and updated to 2.15.1.

It works as expected now: link
Thank you very much again!

@phurichpusapanich
Copy link
Author

Hi @arthurdenner

Thank you for the fast response and fix.

I have upgraded semantic-ui-react-datepickers to the most recent one (2.15.2) and have confirmed that the problem has been fixed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants