Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical fix!!! ( Romanian will not work without) #726

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

kmoutzou
Copy link
Contributor

I just realized the coworker that made the Romanian translation translated also two of the keys. The locale will not work without this fix, crashing the component. Please accept the change!

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

I just realized the coworker that made the Romanian translation translated also two of the keys. The locale will not work without this fix, crashing the component. Please accept the change!
@vercel
Copy link

vercel bot commented Feb 25, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/FFBiAYTNRHaBVrLSru9hdUqHGyf2
✅ Preview: https://react-semantic-ui-datepickers-git-fork-kmou-aee28b-arthurdenner.vercel.app

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #726 (b1af001) into develop (f4d4189) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #726      +/-   ##
===========================================
- Coverage    95.41%   95.25%   -0.16%     
===========================================
  Files           16       16              
  Lines          523      527       +4     
  Branches       102      102              
===========================================
+ Hits           499      502       +3     
- Misses          24       25       +1     
Impacted Files Coverage Δ
src/pickers/range.tsx 86.36% <0.00%> (-1.14%) ⬇️
src/index.tsx 93.88% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cf89e5...b1af001. Read the comment docs.

@arthurdenner
Copy link
Owner

Hi, @kmoutzou! 👋🏽

Thank you for the fix!

I'm sorry for missing this during the code review.
I'll make sure we have checks in place to prevent this from happening again.

@arthurdenner arthurdenner merged commit 8b6588b into arthurdenner:develop Feb 25, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.16.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arthurdenner
Copy link
Owner

@kmoutzou, there is a simple script to validate the files now to reduce the chances of a similar error happening.
Thanks again for finding the issue and sending a fix. 👍🏽

@arthurdenner
Copy link
Owner

@allcontributors please add @kmoutzou for code.

@allcontributors
Copy link
Contributor

@arthurdenner

@kmoutzou already contributed before to code

@kmoutzou
Copy link
Contributor Author

@arthurdenner thanks and welldone! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants