-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Critical fix!!! ( Romanian will not work without) #726
Conversation
I just realized the coworker that made the Romanian translation translated also two of the keys. The locale will not work without this fix, crashing the component. Please accept the change!
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/arthurdenner/react-semantic-ui-datepickers/FFBiAYTNRHaBVrLSru9hdUqHGyf2 |
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
===========================================
- Coverage 95.41% 95.25% -0.16%
===========================================
Files 16 16
Lines 523 527 +4
Branches 102 102
===========================================
+ Hits 499 502 +3
- Misses 24 25 +1
Continue to review full report at Codecov.
|
Hi, @kmoutzou! 👋🏽 Thank you for the fix! I'm sorry for missing this during the code review. |
🎉 This PR is included in version 2.16.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@kmoutzou, there is a simple script to validate the files now to reduce the chances of a similar error happening. |
@allcontributors please add @kmoutzou for code. |
@kmoutzou already contributed before to code |
@arthurdenner thanks and welldone! :) |
I just realized the coworker that made the Romanian translation translated also two of the keys. The locale will not work without this fix, crashing the component. Please accept the change!
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Checklist: