feat(datepicker): Rename props and update onChange signature #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is pending on deseretdigital/dayzed#34 to be completed
…ents from React Semantic UI we are now passing the event or undefined as the first argument and a data object with the props and the new value as the second argument BREAKING CHANGE: onDateChange signature was changed
this change is to match the API with others components from React Semantic UI BREAKING CHANGE: onDateChange prop was renamed to onChange
this change is to match the API with others components from React Semantic UI BREAKING CHANGE: selected prop was renamed to value
arthurdenner
added
enhancement
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/arthurdenner/react-semantic-ui-datepickers/lvjxtqwkda |
emersonlaurentino
approved these changes
Oct 24, 2019
No reason. I just happened to add it as the second argument. Do you think it's better to have it as the first for consistency or any other reason? |
Yes, once React Semantic UI uses this pattern. |
emersonlaurentino
requested changes
Oct 25, 2019
emersonlaurentino
approved these changes
Oct 25, 2019
arthurdenner
added a commit
that referenced
this pull request
Nov 12, 2019
BREAKING CHANGE: onDateChange signature was changed BREAKING CHANGE: onDateChange prop was renamed to onChange BREAKING CHANGE: selected prop was renamed to value
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature. Closes #30.
What is the current behavior?
Our component has a different API from the other components from React Semantic UI.
The main differences are:
onChange;value;onChangeprops on RSUI is: (event: SyntheticEvent, data: ComponentProps).What is the new behavior?
All the points mentioned above are addressed.
Checklist: