Fix compiler warnings (ARMmbed#1957)

Author: Arto Kinnunen

source/6LoWPAN/Thread/thread_extension.c

@@ -242,7 +242,7 @@ static int thread_extension_reset_req_cb(int8_t service_id, uint8_t source_addre
 
     if ((session_id != thread_info(cur)->registered_commissioner.session_id) /*|| (signature_ptr == NULL)*/) {  // todo: signature may not come in this early phase of implementors
         tr_debug("Request parse failed");
-        ptr = thread_meshcop_tlv_data_write_uint8(ptr, MESHCOP_TLV_STATE, -1);
+        ptr = thread_meshcop_tlv_data_write_uint8(ptr, MESHCOP_TLV_STATE, 0xff);
     }
 
     // Downgrade if router
@@ -289,7 +289,7 @@ static int thread_extension_reenroll_req_cb(int8_t service_id, uint8_t source_ad
     if ((session_id != thread_info(cur)->registered_commissioner.session_id) ||/* (signature_ptr == NULL) || */
             thread_extension_primary_bbr_get(cur, pbbr_addr, NULL, NULL, NULL)) {
         tr_debug("Request parse failed");
-        ptr = thread_meshcop_tlv_data_write_uint8(ptr, MESHCOP_TLV_STATE, -1);
+        ptr = thread_meshcop_tlv_data_write_uint8(ptr, MESHCOP_TLV_STATE, 0xff);
         goto send_response;
     }
 

source/6LoWPAN/Thread/thread_extension_bbr.c

@@ -392,7 +392,7 @@ static int thread_pbbr_sec_data_set_recv_cb(int8_t service_id, uint8_t source_ad
     uint8_t *ptr = response;
 
     // This is not yet supported, thus return state TLV rejected
-    ptr = thread_meshcop_tlv_data_write_uint8(response, MESHCOP_TLV_STATE, -1);
+    ptr = thread_meshcop_tlv_data_write_uint8(response, MESHCOP_TLV_STATE, 0xff);
 
     coap_service_response_send(service_id, COAP_REQUEST_OPTIONS_NONE, request_ptr, COAP_MSG_CODE_RESPONSE_CHANGED, COAP_CT_OCTET_STREAM, response, ptr - response);
 

source/6LoWPAN/Thread/thread_router_bootstrap.c

@@ -1949,9 +1949,9 @@ void thread_router_bootstrap_mle_receive_cb(int8_t interface_id, mle_message_t *
                 uint32_t timeout = 0;
                 uint64_t active_timestamp = 0;
                 uint64_t pending_timestamp = 0;
-                mle_tlv_info_t addressRegisterTlv = {0};
-                mle_tlv_info_t challengeTlv = {0};
-                mle_tlv_info_t tlv_req = {0};
+                mle_tlv_info_t addressRegisterTlv = {MLE_TYPE_SRC_ADDRESS, 0, 0};
+                mle_tlv_info_t challengeTlv = {MLE_TYPE_SRC_ADDRESS, 0, 0};
+                mle_tlv_info_t tlv_req = {MLE_TYPE_SRC_ADDRESS, 0, 0};
                 entry_temp = mac_neighbor_entry_get_by_ll64(mac_neighbor_info(cur), mle_msg->packet_src_address, false, NULL);
 
                 if (mle_tlv_read_8_bit_tlv(MLE_TYPE_STATUS, mle_msg->data_ptr, mle_msg->data_length, &status)) {

source/6LoWPAN/ws/ws_bootstrap.c

@@ -356,8 +356,8 @@ static int8_t ws_fhss_initialize(protocol_interface_info_entry_t *cur)
         }
 
         fhss_configuration.fhss_uc_dwell_interval = cur->ws_info->fhss_uc_dwell_interval;
-        fhss_configuration.ws_uc_channel_function = cur->ws_info->fhss_uc_channel_function;
-        fhss_configuration.ws_bc_channel_function = cur->ws_info->fhss_bc_channel_function;
+        fhss_configuration.ws_uc_channel_function = (fhss_ws_channel_functions)cur->ws_info->fhss_uc_channel_function;
+        fhss_configuration.ws_bc_channel_function = (fhss_ws_channel_functions)cur->ws_info->fhss_bc_channel_function;
         fhss_configuration.fhss_bc_dwell_interval = cur->ws_info->fhss_bc_dwell_interval;
         fhss_configuration.fhss_broadcast_interval = cur->ws_info->fhss_bc_interval;
 
@@ -386,8 +386,8 @@ static int8_t ws_fhss_initialize(protocol_interface_info_entry_t *cur)
 static int8_t ws_fhss_set_defaults(protocol_interface_info_entry_t *cur, fhss_ws_configuration_t *fhss_configuration)
 {
     fhss_configuration->fhss_uc_dwell_interval = cur->ws_info->fhss_uc_dwell_interval;
-    fhss_configuration->ws_uc_channel_function = cur->ws_info->fhss_uc_channel_function;
-    fhss_configuration->ws_bc_channel_function = cur->ws_info->fhss_bc_channel_function;
+    fhss_configuration->ws_uc_channel_function = (fhss_ws_channel_functions)cur->ws_info->fhss_uc_channel_function;
+    fhss_configuration->ws_bc_channel_function = (fhss_ws_channel_functions)cur->ws_info->fhss_bc_channel_function;
     fhss_configuration->fhss_bc_dwell_interval = cur->ws_info->fhss_bc_dwell_interval;
     fhss_configuration->fhss_broadcast_interval = cur->ws_info->fhss_bc_interval;
     if (cur->ws_info->fhss_uc_fixed_channel != 0xffff) {
@@ -405,7 +405,9 @@ static int8_t ws_fhss_set_defaults(protocol_interface_info_entry_t *cur, fhss_ws
 static int8_t ws_fhss_border_router_configure(protocol_interface_info_entry_t *cur)
 {
     // Read configuration of existing FHSS and start using the default values for any network
-    fhss_ws_configuration_t fhss_configuration = {0};
+    fhss_ws_configuration_t fhss_configuration;
+    memset(&fhss_configuration, 0, sizeof(fhss_ws_configuration_t));
+
     if (ns_fhss_ws_configuration_get(cur->ws_info->fhss_api)) {
         memcpy(&fhss_configuration, ns_fhss_ws_configuration_get(cur->ws_info->fhss_api), sizeof(fhss_ws_configuration_t));
     }
@@ -428,7 +430,9 @@ static uint16_t ws_randomize_fixed_channel(uint16_t configured_fixed_channel, ui
 static int8_t ws_fhss_discovery_configure(protocol_interface_info_entry_t *cur)
 {
     // Read configuration of existing FHSS and start using the default values for any network
-    fhss_ws_configuration_t fhss_configuration = {0};
+    fhss_ws_configuration_t fhss_configuration;
+    memset(&fhss_configuration, 0, sizeof(fhss_ws_configuration_t));
+
     if (ns_fhss_ws_configuration_get(cur->ws_info->fhss_api)) {
         memcpy(&fhss_configuration, ns_fhss_ws_configuration_get(cur->ws_info->fhss_api), sizeof(fhss_ws_configuration_t));
     }
@@ -487,7 +491,7 @@ static void ws_bootstrap_primary_parent_set(struct protocol_interface_info_entry
     // Learning broadcast network configuration
     if (neighbor_info->ws_neighbor->broadcast_shedule_info_stored) {
         ws_fhss_set_defaults(cur, &fhss_configuration);
-        fhss_configuration.ws_bc_channel_function = neighbor_info->ws_neighbor->fhss_data.bc_timing_info.broadcast_channel_function;
+        fhss_configuration.ws_bc_channel_function = (fhss_ws_channel_functions)neighbor_info->ws_neighbor->fhss_data.bc_timing_info.broadcast_channel_function;
         if (fhss_configuration.ws_bc_channel_function == WS_FIXED_CHANNEL) {
             cur->ws_info->hopping_schdule.bc_fixed_channel = neighbor_info->ws_neighbor->fhss_data.bc_timing_info.fixed_channel;
             cur->ws_info->fhss_bc_fixed_channel = neighbor_info->ws_neighbor->fhss_data.bc_timing_info.fixed_channel;
@@ -1335,7 +1339,7 @@ static bool ws_neighbor_entry_nud_notify(mac_neighbor_table_entry_t *entry_ptr,
             uint16_t switch_prob = randLIB_get_random_in_range(0, probe_period - 1);
             //Take Random from time WS_NEIGHBOR_NUD_TIMEOUT - WS_NEIGHBOR_NUD_TIMEOUT*1.5
             if (switch_prob < 2) {
-                tr_debug("Link Probe test with jitter %u, sample %u", time_from_start, etx_entry->etx_samples);
+                tr_debug("Link Probe test with jitter %"PRIu32", sample %u", time_from_start, etx_entry->etx_samples);
                 activate_nud = true;
             }
         }

source/Security/protocols/sec_prot_certs.h

@@ -83,7 +83,7 @@ void sec_prot_certs_delete(sec_prot_certs_t *certs);
  *
  * \return certificate chain entry or NULL
  */
-cert_chain_entry_t *sec_prot_certs_chain_entry_create();
+cert_chain_entry_t *sec_prot_certs_chain_entry_create(void);
 
 /**
  * sec_prot_certs_chain_entry_init initialize certificate chain entry
@@ -158,7 +158,7 @@ void sec_prot_certs_chain_list_delete(cert_chain_list_t *chain_list);
  *
  * \return certificate revocation list entry or NULL
  */
-cert_revocat_list_entry_t *sec_prot_certs_revocat_list_entry_create();
+cert_revocat_list_entry_t *sec_prot_certs_revocat_list_entry_create(void);
 
 /**
  * sec_prot_certs_revocat_list_entry_init initialize certificate revocation list entry

source/Service_Libs/fhss/channel_functions.c

@@ -162,13 +162,16 @@ static uint32_t dh1cf_hashword(const uint32_t *key, size_t key_length, uint32_t
         key += 3;
     }
     switch (key_length) {
-        case 3 :
+        case 3:
             c += key[2];
-        case 2 :
+        /* fall through */
+        case 2:
             b += key[1];
-        case 1 :
+        /* fall through */
+        case 1:
             a += key[0];
             final(a, b, c);
+        /* fall through */
         case 0:
             break;
     }

source/Service_Libs/fhss/fhss_ws.c

@@ -786,7 +786,7 @@ int fhss_ws_set_parent(fhss_structure_t *fhss_structure, const uint8_t eui64[8],
             // Update clock drift
             fhss_structure->ws->drift_per_millisecond_ns += divide_integer(MS_TO_NS(true_bc_interval_offset - own_bc_interval_offset), US_TO_MS(time_since_last_synch_us));
         }
-        tr_debug("synch to parent: %s, drift: %ims in %u seconds, compensation: %ins per ms", trace_array(eui64, 8), true_bc_interval_offset - own_bc_interval_offset, US_TO_S(time_since_last_synch_us), fhss_structure->ws->drift_per_millisecond_ns);
+        tr_debug("synch to parent: %s, drift: %"PRIi32"ms in %"PRIu32" seconds, compensation: %"PRIi32"ns per ms", trace_array(eui64, 8), true_bc_interval_offset - own_bc_interval_offset, US_TO_S(time_since_last_synch_us), fhss_structure->ws->drift_per_millisecond_ns);
     }
     return 0;
 }
@@ -822,7 +822,7 @@ int fhss_ws_configuration_set(fhss_structure_t *fhss_structure, const fhss_ws_co
         fhss_structure->rx_channel = fhss_configuration->unicast_fixed_channel;
     }
     platform_exit_critical();
-    tr_info("fhss Configuration set, UC channel: %d, BC channel: %d, UC CF: %d, BC CF: %d, channels: %d, uc dwell: %d, bc dwell: %d, bc interval: %d, bsi:%d",
+    tr_info("fhss Configuration set, UC channel: %d, BC channel: %d, UC CF: %d, BC CF: %d, channels: %d, uc dwell: %d, bc dwell: %d, bc interval: %"PRIu32", bsi:%d",
             fhss_structure->ws->fhss_configuration.unicast_fixed_channel,
             fhss_structure->ws->fhss_configuration.broadcast_fixed_channel,
             fhss_structure->ws->fhss_configuration.ws_uc_channel_function,