Usage with AssertJ possible?

[hansjoergkeser]

Hi Artem,

nice extension, it works good with JUnit 5 Assertions.
Unfortunately it does not seem to work with JUnit 5 and AssertJ. I configured the RepeatedIfExceptionsTest annotation with
exceptions = Error.class
or
AssertionFailedError
AssertionError

parameter, but each test is only run once.

[artsok]

Hi, I unfortunately don't have time to fixed it. If u could, make PR do it please.

[perlun]

@hansjoergkeser It would be interesting to hear more about this. We are also using AssertJ with our tests, but they seem to play well with rerunner-jupiter AFAICT. Note though that this is not with RepeatedIfExceptionsTest but with ParameterizedRepeatedIfExceptionsTest:

Would you mind supplying a minimal reproducible example that illustrates the problem you're seeing, if it's still active?

[hansjoergkeser]

@perlun thx for the hint. My description was not detailed enough: I meant AssertJ SoftAssertions. They collect all AssertionFailedError and throw one AssertJMultipleFailuresError in the end. I unsuccessfully tried to configure the rerunner accordingly

`package hajo;

import io.github.artsok.RepeatedIfExceptionsTest;
import org.assertj.core.api.SoftAssertions;
import org.assertj.core.api.junit.jupiter.SoftAssertionsExtension;
import org.assertj.core.error.AssertJMultipleFailuresError;
import org.junit.jupiter.api.extension.ExtendWith;

import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertFalse;

@ExtendWith(SoftAssertionsExtension.class)
public class MyTests {

@RepeatedIfExceptionsTest(repeats = 3)
void testWithJUnit() {
    assertFalse(true, "Fail by JUnit ´hard´ assertion: org.opentest4j.AssertionFailedError");
}

@RepeatedIfExceptionsTest(repeats = 3)
void testWithAssertJ_Soft_Default(SoftAssertions softAssertions) {
    softAssertions.assertThat(1)
            .as("Fail by AssertJ ´soft´ assertion: org.assertj.core.error.AssertJMultipleFailuresError")
            .isEqualTo(2);
}

@RepeatedIfExceptionsTest(repeats = 3, exceptions = AssertJMultipleFailuresError.class)
void testWithAssertJ_Soft(SoftAssertions softAssertions) {
    softAssertions.assertThat(1)
            .as("Fail by AssertJ ´soft´ assertion: org.assertj.core.error.AssertJMultipleFailuresError")
            .isEqualTo(2);
}

@RepeatedIfExceptionsTest(repeats = 3)
void testWithAssertJ_Hard() {
    assertThat(1)
            .as("Fail by AssertJ ´hard´ assertion: org.opentest4j.AssertionFailedError")
            .isEqualTo(2);
}

}
`

[hansjoergkeser]

If I have time ill try to investigate how these soft assertions exactly work.
https://github.com/hansjoergkeser/rerunner-jupiter-arstok