You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
So, any field relating to bidding that was of the form _cents (such as estimate_cents), now will also include a display_estimate_dollars field. This field (a string), will include any currency information, as well as proper formatting/rounding.
This makes it easier to actually put on a non USD auction, as clients can become 'dumber' and just render these fields directly, rather than doing a divide by 100 and add a $ sign, type thing.
This is fully backwards-compatible (it's just extra JSON) so no rush, but it would be nice (and I think net code deletion for you guys) to switch to this.
Here's an example of how Force was updated to use it: artsy/force#3334
Will open this issue in Eidolon as well.
Thanks guys! Let me know if you have questions.
The text was updated successfully, but these errors were encountered:
In order to enable non USD auctions, recent PR's in gravity (https://github.com/artsy/gravity/pull/9179 as an example), has added JSON fields to help currency formatting.
So, any field relating to bidding that was of the form
_cents
(such asestimate_cents
), now will also include adisplay_estimate_dollars
field. This field (a string), will include any currency information, as well as proper formatting/rounding.This makes it easier to actually put on a non USD auction, as clients can become 'dumber' and just render these fields directly, rather than doing a
divide by 100 and add a $ sign
, type thing.This is fully backwards-compatible (it's just extra JSON) so no rush, but it would be nice (and I think net code deletion for you guys) to switch to this.
Here's an example of how Force was updated to use it: artsy/force#3334
Will open this issue in Eidolon as well.
Thanks guys! Let me know if you have questions.
The text was updated successfully, but these errors were encountered: