Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when running an outdated version #86

Closed
izakp opened this issue Sep 25, 2018 · 5 comments
Closed

Warning when running an outdated version #86

izakp opened this issue Sep 25, 2018 · 5 comments
Assignees
Labels
medium medium importance

Comments

@izakp
Copy link
Contributor

izakp commented Sep 25, 2018

@alloy Not sure how to approach this other than checking https://pypi.org/project/hokusai/#history every time Hokusai runs, which seems excessive

Perhaps somehow tying it to the project config would be better

@izakp izakp self-assigned this Sep 25, 2018
@alloy
Copy link
Contributor

alloy commented Sep 25, 2018

Yeah good question. Maybe we can identify certain commands where it really matters? I assume there’s no other requests that are regularly made anyways that we could piggy-back off?

@dblandin
Copy link
Member

What if we were to track releases via GitHub and check once every X interval (hour, day, etc) across any Hokusai command?

Upon any command execution, if we haven't checked within the past X interval, hit the GitHub API and compare versions. If the local Hokusai is out of date, show a warning? Maybe prompt to upgrade or continue?

https://api.github.com/repos/artsy/hokusai/releases/latest

@alloy
Copy link
Contributor

alloy commented Nov 14, 2018

Yeah good point, at most once an hour is probably a good interval, but then I do think we should do it synchronously before the command does any other work and maybe even ask:

There’s a new version, are you sure you want to continue this with an outdated version? [y/N]

@dblandin
Copy link
Member

I do think we should do it synchronously before the command does any other work and maybe even ask

I like that! 👍

@izakp izakp mentioned this issue Nov 16, 2018
@artsyjian artsyjian added medium medium importance and removed enhancement labels Apr 24, 2022
@artsyjian
Copy link
Contributor

closing in favor of #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium medium importance
Projects
None yet
Development

No branches or pull requests

4 participants