Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(navview): use span instead of link to avoid nested links #97

Merged

Conversation

arturmiz
Copy link
Owner

Closes #89

@arturmiz arturmiz added the component: navview NavView component issues label Jan 16, 2020
@arturmiz arturmiz self-assigned this Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          40     40           
  Lines         263    263           
  Branches       36     36           
=====================================
  Hits          263    263
Impacted Files Coverage Δ
src/components/navview/MenuItem.vue 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2c947...5cd9c58. Read the comment docs.

@arturmiz arturmiz merged commit ef5384e into master Jan 18, 2020
@arturmiz arturmiz deleted the fix/navview/vue-router-link-doesnt-play-well-with-menu-item-89 branch January 18, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: navview NavView component issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavView vue-router's router-link doesn't play well with menu item
1 participant