Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: floating bar extra data preservation #139

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

artus9033
Copy link
Owner

Describe your changes

This PR introduces changes requested by the community in #81, allowing for preservation of extra data in data points of array shape (floating bar). Although these are not supported officially in chart.js documentation, since the original issue mentioned the need for such support and chart.js code also seems to operate only on indices, not blocking extending the size of this data point shape, the code style may be adjusted to not interfere with the shape of array data points.

Closes #81.

Linked issues (if any)

Checklist before requesting a review

  • E2E tests' snapshots (screenshots) are up-to-date
  • documentation is up-to-date

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (429643c) to head (8695759).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   78.64%   78.75%   +0.11%     
==========================================
  Files           1        1              
  Lines         192      193       +1     
  Branches       78       78              
==========================================
+ Hits          151      152       +1     
  Misses         41       41              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artus9033 artus9033 merged commit 2e9867d into master Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra data being removed for the range bar
1 participant