Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile. #1579

Open
thenetimp opened this issue Nov 29, 2020 · 3 comments
Open

Fails to compile. #1579

thenetimp opened this issue Nov 29, 2020 · 3 comments

Comments

@thenetimp
Copy link

tp -I src/http/modules
-o objs/addon/nginx-rtmp-module/ngx_rtmp_eval.o
../nginx-rtmp-module/ngx_rtmp_eval.c
../nginx-rtmp-module/ngx_rtmp_eval.c: In function 'ngx_rtmp_eval':
../nginx-rtmp-module/ngx_rtmp_eval.c:160:17: error: this statement may fall through [-Werror=implicit-fallthrough=]
160 | switch (c) {
| ^~~~~~
../nginx-rtmp-module/ngx_rtmp_eval.c:170:13: note: here
170 | case ESCAPE:
| ^~~~
cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:1339: objs/addon/nginx-rtmp-module/ngx_rtmp_eval.o] Error 1
make[1]: Leaving directory '/usr/src/nginx'
make: *** [Makefile:8: build] Error 2


I got around this by removing the -Werror in objs/Makefile in nginx source, but this isn't ideal when you want to built this automated or in a dockerfile. I'd try to fix it myself, but not sure what the fix should be.

@shortcord
Copy link

Another way is listed in #1569.

@thenetimp
Copy link
Author

cool I'll give it a try, and if it works I'll close the ticket.

@cmnajs
Copy link

cmnajs commented Dec 24, 2020

Not sure about your setup but this Dockerfile is building successfully. I hope it would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants