Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Python type stubs into bindings/python/libtorrent #7690

Closed
qstokkink opened this issue Jun 27, 2024 · 1 comment
Closed

Move Python type stubs into bindings/python/libtorrent #7690

qstokkink opened this issue Jun 27, 2024 · 1 comment

Comments

@qstokkink
Copy link

libtorrent version (or branch): master

While creating the fixes of #7688, I spotted one optimization to the current directory structure: the Python type stubs can be moved from bindings/python/install_data/libtorrent into bindings/python/libtorrent.

This change would obsolete the following code in its entirety.

# Our stubs end up in the "libtorrent" directory in the wheel.
# Setuptools expects it to exist beforehand.
if not os.path.exists("libtorrent"):
os.mkdir("libtorrent")
try:
shutil.copytree("install_data/libtorrent", "libtorrent")
except FileExistsError:
pass

Even though the code above can be removed, all paths that point to install_data would have to be updated.

@qstokkink qstokkink changed the title Move Python type stubs into Move Python type stubs into bindings/python/libtorrent Jun 27, 2024
@qstokkink
Copy link
Author

Fixed in #7691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant