Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Khat deprecate annotate in favor of threshold #1478

Merged
merged 4 commits into from
Dec 28, 2020
Merged

Khat deprecate annotate in favor of threshold #1478

merged 4 commits into from
Dec 28, 2020

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Dec 24, 2020

Replace annotate argument with threshold, this makes plot_khat more consistent with plot_elpd and also allows user to define arbitrary values to use as thresholds. This also add a few tweaks to make it easier to use plot_khat with subplots and share the Y-axis.

  • Follows official PR format
  • New features are properly documented (with an example if appropriate)?
  • Includes new or updated tests to cover the new feature
  • Code style correct (follows pylint and black guidelines)
  • Changes are listed in changelog

@aloctavodia aloctavodia changed the title [Khat [WIP] Khat tweak Dec 24, 2020
@aloctavodia aloctavodia changed the title [WIP] Khat tweak Khat deprecate annotate in favor of threshold Dec 26, 2020
@codecov
Copy link

codecov bot commented Dec 26, 2020

Codecov Report

Merging #1478 (32d8768) into master (8fd104c) will decrease coverage by 0.00%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   91.98%   91.97%   -0.01%     
==========================================
  Files         105      105              
  Lines       11222    11239      +17     
==========================================
+ Hits        10322    10337      +15     
- Misses        900      902       +2     
Impacted Files Coverage Δ
arviz/plots/khatplot.py 94.87% <60.00%> (-5.13%) ⬇️
arviz/plots/backends/bokeh/khatplot.py 98.59% <100.00%> (+0.08%) ⬆️
arviz/plots/backends/matplotlib/khatplot.py 75.00% <100.00%> (ø)
arviz/plots/backends/matplotlib/traceplot.py 98.80% <0.00%> (+<0.01%) ⬆️
arviz/plots/backends/matplotlib/loopitplot.py 98.76% <0.00%> (+0.01%) ⬆️
arviz/plots/backends/bokeh/traceplot.py 94.47% <0.00%> (+0.03%) ⬆️
arviz/plots/backends/bokeh/loopitplot.py 94.87% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd104c...32d8768. Read the comment docs.

@canyon289
Copy link
Member

LGTM code wise. Do we need to update any tests? Its fine if theyre not updated on this PR, we can open up an issue ticket to track

@aloctavodia aloctavodia merged commit 2d202de into master Dec 28, 2020
@aloctavodia aloctavodia deleted the khat branch December 28, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants