-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGTERM / SIGINT signal gracefully #47
Comments
I didn't handle this case because, i wanted to give user chance to continue from where it is left off, if he re-runs the command, maybe we can leave a note to user. Sometimes people accidently press (control + c) or even if our program panics and cancels, why delete the files so the user has to spend time again to start from beginning. |
Once the process is interrupted it is going to leave segment files (potentially uncompleted) that are not usable in the next try if I understand correctly? |
Good point, we need to verify this doubt and also read necessary docs for io library. Please create an issue for this we will investigate. but if there is a log "Downloaded segment ..", that proves those segment downloaded successfully
Actually no, session ID = Hash(URL,threadcount) . so, with same params, we get same session ID and hence download resumes, we infact show a message to user that we are resuming download |
/good-first-issue |
The process doesn't clean up the temp directory created for segment storage when it receives SIGTERM / SIGINT signal.
The text was updated successfully, but these errors were encountered: