Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for char and string #125

Merged
merged 17 commits into from
Oct 28, 2024
Merged

feat: Add support for char and string #125

merged 17 commits into from
Oct 28, 2024

Conversation

vikasgrewal16
Copy link
Contributor

@vikasgrewal16 vikasgrewal16 commented Oct 21, 2024 •
edited
Loading

Pull Request description

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Reviewer's Checklist

  • I managed to reproduce the problem locally from the main branch
  • I managed to test the new changes locally
  • I confirm that the issues mentioned were fixed/resolved .

xmnlab
xmnlab reviewed Oct 27, 2024
View reviewed changes
git rebase -i HEAd~x Outdated Show resolved Hide resolved
xmnlab
xmnlab requested changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikasgrewal16 , thanks for working on that.

I just added a comment here about the transpiler.
please also add tests for cases with quotation marks:

for example: " 'a' " and ' "a" '

what I meam by that, is that test two different values for quotation marks, one with single quotes inside, and another one with double quotes inside.

@vikasgrewal16 vikasgrewal16 requested a review from xmnlab October 28, 2024 09:12
xmnlab
xmnlab requested changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vikasgrewal16 !
Please add the typechecked decorator to the new classes

src/astx/datatypes.py Show resolved Hide resolved
src/astx/datatypes.py Show resolved Hide resolved
src/astx/datatypes.py Show resolved Hide resolved
src/astx/datatypes.py Show resolved Hide resolved
@xmnlab xmnlab changed the title feat: adding support for char and string feat: Add support for char and string Oct 28, 2024
xmnlab
xmnlab approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on that, @vikasgrewal16

@xmnlab xmnlab merged commit 7b8f52d into arxlang:main Oct 28, 2024
12 checks passed
@vikasgrewal16 vikasgrewal16 deleted the utf8 branch October 28, 2024 15:57
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmnlab xmnlab xmnlab approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikasgrewal16 @xmnlab